chore: Rename path variables for clarity

[sambuc]

PR Stack

• feat: Upload secrets to HPC cluster #1159
• chore: Always allocate the StringData map #1160
• chore: Add OIDC config only when needed #1161
• chore: Refactor tunnelSecret handling #1162
• 🐸 chore: Rename path variables for clarity #1163

[leafty]

Not sure I understand which type of clarity I gain by having srun prefixed everywhere.

[sambuc]

I spend quite some time before realising this code was managing 3 sets of paths:

1. The paths in the proxy container
2. The paths on the node as seen by the srun command.
3. The paths within the (final) user container

And figuring out which was which and when it was used.

Maybe I should have prefixed with something else but it was necessary for me to be a bit more explicit about what the variables were holding.

[leafty]

I spend quite some time before realising this code was managing 3 sets of paths:

1. The paths in the proxy container
2. The paths on the node as seen by the srun command.
3. The paths within the (final) user container

And figuring out which was which and when it was used.

Maybe I should have prefixed with something else but it was necessary for me to be a bit more explicit about what the variables were holding.

How about:

• localX local file path, can be read from os.Read()
• remoteX, remote file path, created by calling Firecrest
• containerX, path inside the session container