feat: Mount DC in HPC sessions - #1174
Open
sambuc wants to merge 1 commit into
Open
Conversation
leafty
reviewed
Jul 17, 2026
Comment on lines
+51
to
+56
| # Do not leave secrets on a shared fs, move it to the node where the session runs. | ||
| mkdir -p "${SECRETS_DIR}" | ||
| chmod 700 "${SECRETS_DIR}" | ||
| mv "${SESSION_DIR}/secrets"/* "${SECRETS_DIR}" | ||
| rmdir "${SESSION_DIR}/secrets" | ||
|
|
Member
There was a problem hiding this comment.
Why do we do this? Official CSCS docs have example where user credentials are stored in the HOME folder. I really do not see what we gain by doing this.
Example: https://docs.cscs.ch/software/container-engine/run/#third-party-and-private-registries
Having the credentials in the HOME folder allows user to re-access the data connectors even outside of a remote Renku session (e.g. connecting directly to Alps with SSH).
Comment on lines
+245
to
+247
| # We do our best to make sure we do not leave around bad rclone | ||
| # state, but sometimes there is still something lingering on... | ||
| # so we have to add --allow-non-empty. |
Member
There was a problem hiding this comment.
Why not do rm -rf <mount_point>; mkdir -p <mount_point>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack