feat: adapt requeuing when session is hibernated - #1185
Open
sgaist wants to merge 1 commit into
Open
Conversation
Once a pod has been hibernated, queue for the MaxHibernationDuration. If it's awaken before, there will be an event and otherwise, it avoids checking it every 10 seconds.
leafty
requested changes
Jul 21, 2026
leafty
left a comment
leafty
left a comment
Member
There was a problem hiding this comment.
This change prevents prometheus metrics to be collected for a paused session.
See:
Collaborator
Author
|
Thinking about this a bit more:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently, the operator checks on all sessions every 10 seconds.
This is not needed anymore once a pod has been hibernated.
Therefore queue for the MaxHibernationDuration.
If it's awaken before, there will be an event that will trigger an earlier reconciliation.