feat: delete session Ingress on hibernation - #1190
Open
sgaist wants to merge 7 commits into
Open
Conversation
There is no reason to keep it alive while the session is unreachable anyway. It will be recreated when the session resumes.
Sometimes the awakening the session fails because the update clashes with changes that have happened through the operator. Simply update and retry.
Only one of them makes sense at a time. This reduces the number of reconciliation happening.
olevski
previously approved these changes
Jul 24, 2026
leafty
reviewed
Jul 24, 2026
leafty
left a comment
leafty
left a comment
Member
There was a problem hiding this comment.
We should deploy and test before merging.
Contributor
|
You can access the deployment of this PR at https://renku-ci-am-1190.dev.renku.ch |
leafty
reviewed
Jul 30, 2026
leafty
left a comment
leafty
left a comment
Member
There was a problem hiding this comment.
We may need to update the rbac here:
2026-07-30T13:45:26Z ERROR Reconciler error {"controller": "amaltheasession", "controllerGroup": "amalthea.dev", "controllerKind": "AmaltheaSession", "AmaltheaSession": {"name":"flora-thieba-b5c436075d08","namespace":"renku-ci-am-1190"}, "namespace": "renku-ci-am-1190", "name": "flora-thieba-b5c436075d08", "reconcileID": "0b7948c8-081f-4671-be9d-2cc25ebccc1a", "error": "error in reconciling children Ingress: ingresses.networking.k8s.io \"flora-thieba-b5c436075d08\" is forbidden: User \"system:serviceaccount:renku-ci-am-1190:renku-ci-am-1190-amalthea-sessions-controller-manager\" cannot delete resource \"ingresses\" in API group \"networking.k8s.io\" in the namespace \"renku-ci-am-1190\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:353
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:300
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.21.0/pkg/internal/controller/controller.go:202
leafty
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR implements the removal of hibernated session Ingress.
Once the session is reactivated, the Ingress will be recreated.
Links and tickets
Fixes #1036
/deploy