Skip to content

chore: make limits the same as request for sidecar containers #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgaist wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: make limits the same as request for sidecar containers #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567f55a
chore: use same value for requests and limits in sidecar containers
sgaist Jul 24, 2026
a2b1944
Merge branch 'main' into chore/limits-equal-requests
sgaist Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1alpha1/amaltheasession_children.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ func (cr *AmaltheaSession) sessionContainerRemote(volumeMounts []v1.VolumeMount)
"cpu": resource.MustParse("100m"),
},
Limits: v1.ResourceList{
"memory": resource.MustParse("128Mi"),
"memory": resource.MustParse("64Mi"),
// NOTE: Cpu limit not set on purpose
// Without cpu limit if there is spare you can go over the request
// If there is no spare cpu then all things get throttled relative to their request
Expand Down Expand Up @@ -1101,7 +1101,7 @@ func (cr *AmaltheaSession) tunnelContainer() v1.Container {
"cpu": resource.MustParse("100m"),
},
Limits: v1.ResourceList{
"memory": resource.MustParse("128Mi"),
"memory": resource.MustParse("64Mi"),
// NOTE: Cpu limit not set on purpose
// Without cpu limit if there is spare you can go over the request
// If there is no spare cpu then all things get throttled relative to their request
Expand Down
6 changes: 3 additions & 3 deletions api/v1alpha1/auth_templates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (as *AmaltheaSession) auth() (manifests, error) {
"cpu": resource.MustParse("20m"),
},
Limits: v1.ResourceList{
"memory": resource.MustParse("32Mi"),
"memory": resource.MustParse("16Mi"),
// NOTE: Cpu limit not set on purpose
// Without cpu limit if there is spare you can go over the request
// If there is no spare cpu then all things get throttled relative to their request
Expand Down Expand Up @@ -204,7 +204,7 @@ func (as *AmaltheaSession) auth() (manifests, error) {
"cpu": resource.MustParse("20m"),
},
Limits: v1.ResourceList{
"memory": resource.MustParse("32Mi"),
"memory": resource.MustParse("16Mi"),
// NOTE: Cpu limit not set on purpose
// Without cpu limit if there is spare you can go over the request
// If there is no spare cpu then all things get throttled relative to their request
Expand Down Expand Up @@ -260,7 +260,7 @@ func (as *AmaltheaSession) get_rewrite_authn_proxy(listenPort int32, metaListenP
"cpu": resource.MustParse("20m"),
},
Limits: v1.ResourceList{
"memory": resource.MustParse("32Mi"),
"memory": resource.MustParse("16Mi"),
// NOTE: Cpu limit not set on purpose
// Without cpu limit if there is spare you can go over the request
// If there is no spare cpu then all things get throttled relative to their request
Expand Down
Loading