refactor:crd deployment#952
Merged
Merged
Conversation
sgaist
force-pushed
the
refactor/crd-deployment
branch
2 times, most recently
from
ef851a8 to
73d79e1
Compare
olevski
requested changes
Jun 27, 2025
olevski
left a comment
olevski
left a comment
Member
There was a problem hiding this comment.
Just have one question about the RBAC changes.
olevski
approved these changes
Jul 1, 2025
This follow the rational expressed by the helm authors: - <https://github.com/helm/community/blob/main/hips/hip-0011.md> TLDR: modifying a CRD (update, deletion) should be a manual process because the ramifications are quite complex (CR deletion for example). CRD deployment can be skipped using the --skip-crds option. Some related issues: - <helm/helm#5871> - <helm/helm#7735> - <helm/helm#10585>
This can be done at helm level using the --skip-crds option since the CRDs have been moved to the crds folder.
While it's possible to have multiple apiGroups and resources, the list made would not apply on OpenShift. The generated lists would contain invalid entries such as networking items in the apps group and all the combinations possible.
The original code appends to the file rather than overwriting its content.
sgaist
force-pushed
the
refactor/crd-deployment
branch
from
73d79e1 to
745fa66
Compare
olevski
added a commit
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR refactors the CRD deployment part of the amalthea and amalthea-session helm charts.
The management of the CRD, while looking simple, is in fact quite complex in its consequences.
Hence we will follow the current recommendation of the Helm maintainers.
More information about the reasoning can be found at:
https://github.com/helm/community/blob/main/hips/hip-0011.md
The RBAC cleanup will also allow for deployment on OpenShift.