feat: add children labels and annotations#964
Conversation
89092ab to
85e55ce
Compare
49d9f2b to
7ef9f3b
Compare
leafty
left a comment
There was a problem hiding this comment.
I think you need to re-generate the CRD, it doesn't look up to date.
Yes I reran the codegen and pushed the changes. |
|
You can access the deployment of this PR at https://renku-ci-am-964.dev.renku.ch |
leafty
left a comment
There was a problem hiding this comment.
Looks good to me, but I would merge only after we have a corresponding PR in renku-data-services which show that the template field works as intended.
d9cce15 to
b924fa7
Compare
1140522 to
13fd97a
Compare
So I deployed the CRD and tested manually in the CI deployment. What I did:
|
|
I also added tests for the label and annotation propagation in the go code. |
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
closes #779
In the case of conflicts with selector labels or anything that is set on the children internally for amalthea then the value set from amalthea internally will have precendece.
/deploy