fix: Add standardized logs to gRPC methods

Author: sambuc

pkg/rclone/controllerserver.go

@@ -103,18 +103,23 @@ func (cs *ControllerServer) ValidateVolumeCapabilities(_ context.Context, req *c
 }
 
 // ControllerPublishVolume Attaching Volume
-func (cs *ControllerServer) ControllerPublishVolume(_ context.Context, _ *csi.ControllerPublishVolumeRequest) (*csi.ControllerPublishVolumeResponse, error) {
+func (cs *ControllerServer) ControllerPublishVolume(_ context.Context, req *csi.ControllerPublishVolumeRequest) (*csi.ControllerPublishVolumeResponse, error) {
+	klog.Infof("ControllerPublishVolume called with: %v", *req)
+
 	return nil, status.Errorf(codes.Unimplemented, "method ControllerPublishVolume not implemented")
 }
 
 // ControllerUnpublishVolume Detaching Volume
-func (cs *ControllerServer) ControllerUnpublishVolume(_ context.Context, _ *csi.ControllerUnpublishVolumeRequest) (*csi.ControllerUnpublishVolumeResponse, error) {
+func (cs *ControllerServer) ControllerUnpublishVolume(_ context.Context, req *csi.ControllerUnpublishVolumeRequest) (*csi.ControllerUnpublishVolumeResponse, error) {
+	klog.Infof("ControllerUnpublishVolume called with: %v", *req)
+
 	return nil, status.Errorf(codes.Unimplemented, "method ControllerUnpublishVolume not implemented")
 }
 
 // CreateVolume Provisioning Volumes
 func (cs *ControllerServer) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest) (*csi.CreateVolumeResponse, error) {
-	klog.Infof("ControllerCreateVolume: called with args %+v", *req)
+	klog.Infof("CreateVolume called with: %v", *req)
+
 	volumeName := req.GetName()
 	if len(volumeName) == 0 {
 		return nil, status.Error(codes.InvalidArgument, "CreateVolume name must be provided")
@@ -172,6 +177,8 @@ func (cs *ControllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
 }
 
 func (cs *ControllerServer) DeleteVolume(_ context.Context, req *csi.DeleteVolumeRequest) (*csi.DeleteVolumeResponse, error) {
+	klog.Infof("DeleteVolume called with: %v", *req)
+
 	volId := req.GetVolumeId()
 	if len(volId) == 0 {
 		return nil, status.Error(codes.InvalidArgument, "DeleteVolume must be provided volume id")

pkg/rclone/nodeserver.go

@@ -320,6 +320,8 @@ func getVolumeConfig(ctx context.Context, req *csi.NodeStageVolumeRequest) (*Mou
 }
 
 func (ns *NodeServer) NodeStageVolume(ctx context.Context, req *csi.NodeStageVolumeRequest) (*csi.NodeStageVolumeResponse, error) {
+	klog.Infof("NodeStageVolume called with: %v", *req)
+
 	if err := validateNodeStageVolumeRequest(req); err != nil {
 		return nil, err
 	}
@@ -371,6 +373,8 @@ func validateNodeUnstageVolumeRequest(req *csi.NodeUnstageVolumeRequest) error {
 }
 
 func (ns *NodeServer) NodeUnstageVolume(ctx context.Context, req *csi.NodeUnstageVolumeRequest) (*csi.NodeUnstageVolumeResponse, error) {
+	klog.Infof("NodeUnstageVolume called with: %v", *req)
+
 	if err := validateNodeUnstageVolumeRequest(req); err != nil {
 		return nil, err
 	}
@@ -422,6 +426,8 @@ func validateNodePublishVolumeRequest(req *csi.NodePublishVolumeRequest) error {
 }
 
 func (ns *NodeServer) NodePublishVolume(_ context.Context, req *csi.NodePublishVolumeRequest) (*csi.NodePublishVolumeResponse, error) {
+	klog.Infof("NodePublishVolume called with: %v", *req)
+
 	if err := validateNodePublishVolumeRequest(req); err != nil {
 		return nil, err
 	}
@@ -594,7 +600,8 @@ func extractConfigData(parameters map[string]string) (string, map[string]string)
 
 // Unmounting Volumes
 func (ns *NodeServer) NodeUnpublishVolume(_ context.Context, req *csi.NodeUnpublishVolumeRequest) (*csi.NodeUnpublishVolumeResponse, error) {
-	klog.Infof("NodeUnpublishVolume called with: %s", req)
+	klog.Infof("NodeUnpublishVolume called with: %v", *req)
+
 	if err := validateUnPublishVolumeRequest(req); err != nil {
 		return nil, err
 	}