squashme: address comments

olevski · olevski · commit 573149871fb3 · 2024-11-13T18:02:12.000+01:00
diff --git a/src/vscode/README.md b/src/vscode/README.md
@@ -1,7 +1,7 @@
 
-# Renku CLI (renku)
+# VSCode frontend for Renku sessions
 
-Installs vscode for running in Renku.
+Installs VSCode for running in Renku.
 
 ## Example Usage
 
diff --git a/src/vscode/devcontainer-feature.json b/src/vscode/devcontainer-feature.json
@@ -6,9 +6,10 @@
     "options": {},
     "dependsOn": {
         "ghcr.io/devcontainers-extra/features/vscode-cli:1": {
+            // The version is taken from https://github.com/microsoft/vscode/tags
             "version": "1.95.2"
         }
     }
     "init": true,
-    "entrypoint": "tini -- code serve-web --server-base-path \"$RENKU_BASE_URL_PATH/\" --without-connection-token --host 0.0.0.0 --port 8888"
+    "entrypoint": "tini -- code serve-web --server-base-path $RENKU_BASE_URL_PATH/ --without-connection-token --host 0.0.0.0 --port 8888"
 }

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,10 @@`
`6`	`6`	`"options": {},`
`7`	`7`	`"dependsOn": {`
`8`	`8`	`"ghcr.io/devcontainers-extra/features/vscode-cli:1": {`
	`9`	`+ // The version is taken from https://github.com/microsoft/vscode/tags`
`9`	`10`	`"version": "1.95.2"`
`10`	`11`	`}`
`11`	`12`	`}`
`12`	`13`	`"init": true,`
`13`		`- "entrypoint": "tini -- code serve-web --server-base-path \"$RENKU_BASE_URL_PATH/\" --without-connection-token --host 0.0.0.0 --port 8888"`
	`14`	`+ "entrypoint": "tini -- code serve-web --server-base-path $RENKU_BASE_URL_PATH/ --without-connection-token --host 0.0.0.0 --port 8888"`
`14`	`15`	`}`