chore: fix linting

Author: olevski

Cargo.lock

@@ -33,9 +33,12 @@ pub enum DepositCommand {
 }
 
 impl Input {
-    pub async fn exec(&self, ctx: Context) -> Result<(), Error> {
+    pub async fn exec(&self, _ctx: Context) -> Result<(), Error> {
         match self.subcmd {
-            DatasetCommand::Deposit { cmd: _ } => Ok(print!("Hi")),
+            DatasetCommand::Deposit { cmd: _ } => {
+                print!("Hi");
+                Ok(())
+            }
         }
     }
 }

src/cli/cmd/dataset.rs

@@ -6,7 +6,7 @@ use std::env::VarError;
 use std::path::PathBuf;
 
 #[derive(Debug, Clone, ValueEnum)]
-enum Provider {
+pub enum Provider {
     Zenodo,
 }
 

src/cli/cmd/dataset/deposit.rs

@@ -10,6 +10,7 @@ use walkdir::WalkDir;
 
 use std::io;
 use std::sync::LazyLock;
+
 pub struct ZenodoClient {
     http_client: reqwest::Client,
     base_url: Url,
@@ -38,15 +39,15 @@ pub enum Error {
 impl ZenodoClient {
     pub fn new(token: String) -> ZenodoClient {
         let http_client = reqwest::Client::new();
-        return ZenodoClient {
+        ZenodoClient {
             http_client,
             base_url: BASE_URL.clone(),
             token,
-        };
+        }
     }
 
     fn make_url(&self, path: &str) -> Result<Url, Error> {
-        return self.base_url.join(path).context(UrlParseSnafu);
+        self.base_url.join(path).context(UrlParseSnafu)
     }
 
     pub async fn get_deposition<R: DeserializeOwned>(
@@ -57,11 +58,12 @@ impl ZenodoClient {
         let res = self
             .http_client
             .get(endpoint)
+            .bearer_auth(&self.token)
             .send()
             .await
             .context(ReqwestSnafu)?;
         // res.error_for_status().context(ReqwestSnafu)?;
-        return res.json::<R>().await.context(DeserializeRespSnafu);
+        res.json::<R>().await.context(DeserializeRespSnafu)
     }
 
     pub async fn upload_files(&self, deposition_id: &str, source_path: &Path) -> Result<(), Error> {
@@ -77,11 +79,11 @@ impl ZenodoClient {
         let res = self
             .http_client
             .get(endpoint)
+            .bearer_auth(&self.token)
             .send()
             .await
             .context(ReqwestSnafu)?;
-        // res.error_for_status().context(ReqwestSnafu)?;
-        return res.json::<R>().await.context(DeserializeRespSnafu);
+        res.json::<R>().await.context(DeserializeRespSnafu)
     }
 
     async fn upload_file<R: DeserializeOwned>(
@@ -114,11 +116,11 @@ impl ZenodoClient {
         let res = self
             .http_client
             .post(endpoint)
+            .bearer_auth(&self.token)
             .multipart(form)
             .send()
             .await
             .context(ReqwestSnafu)?;
-        // res.error_for_status().context(ReqwestSnafu)?;
-        return res.json::<R>().await.context(DeserializeRespSnafu);
+        res.json::<R>().await.context(DeserializeRespSnafu)
     }
 }

src/cli/cmd/dataset/zenodo.rs

@@ -13,12 +13,12 @@ use snafu::{ResultExt, Snafu};
 /// The login consists of two parts:
 ///
 /// 1. Renku is queried to return a temporary URL that can be used to
-/// authenticate and authorize this application. The url must be
-/// opened with some device and the user code must be entered (if
-/// necessary).
+///    authenticate and authorize this application. The url must be
+///    opened with some device and the user code must be entered (if
+///    necessary).
 ///
 /// 2. Once the first step is complete, the cli can obtain an access
-/// token and does so by periodically polling the renku platform.
+///    token and does so by periodically polling the renku platform.
 ///
 /// The login command can do these two steps separately. This requires
 /// to run with `--user-code-only` to omit the second step and store
@@ -68,7 +68,7 @@ enum Steps<'a> {
     Complete,
 }
 impl Input {
-    fn get_steps(&self) -> Steps {
+    fn get_steps(&'_ self) -> Steps<'_> {
         if let Some(p) = &self.continue_from {
             Steps::Continue(p)
         } else if self.user_code_only {

src/cli/cmd/login.rs

@@ -114,7 +114,7 @@ impl Input {
     }
 }
 
-async fn clone_project<'a>(
+async fn clone_project(
     ctx: Context,
     project: &ProjectDetails,
     target: PathBuf,

src/cli/cmd/project/clone.rs

@@ -56,7 +56,7 @@ pub struct Versions<'a> {
     pub renku_url: &'a str,
 }
 impl Versions<'_> {
-    pub fn create(server: VersionInfo, renku_url: &str) -> Versions {
+    pub fn create(server: VersionInfo, renku_url: &'_ str) -> Versions<'_> {
         Versions {
             client: BuildInfo::default(),
             server,

src/cli/cmd/version.rs

@@ -30,7 +30,9 @@ async fn execute() -> Result<()> {
 
     let result = rnk::execute_cmd(opts).await;
     if remove_env {
-        env::remove_var(LOG_LEVEL);
+        unsafe {
+            env::remove_var(LOG_LEVEL);
+        }
     }
     result?;
     Ok(())
@@ -39,7 +41,9 @@ async fn execute() -> Result<()> {
 fn set_log_level(level: &str) -> bool {
     let current = env::var_os(LOG_LEVEL);
     if current.is_none() {
-        env::set_var(LOG_LEVEL, level);
+        unsafe {
+            env::set_var(LOG_LEVEL, level);
+        }
         true
     } else {
         false