fix: update GitHub provider to support Enterprise Server (#979)

Closes #974.

Author: leafty

components/renku_data_services/connected_services/dummy_async_oauth2_client.py

@@ -26,7 +26,7 @@ async def get(self, url: str, *args: list, **kwargs: dict) -> Response:
         if parsed.path == "/api/v4/projects/username%2Fmy_repo":
             return self._get_repository_response()
 
-        if parsed.path == "/user/installations":
+        if parsed.path == "/api/v3/user/installations":
             return self._get_installations_response()
 
         return Response(500, json=dict())

components/renku_data_services/connected_services/provider_adapters.py

@@ -78,7 +78,7 @@ def api_validate_account_response(self, response: Response) -> models.ConnectedA
 
 
 class GitHubAdapter(ProviderAdapter):
-    """Adapter for GitLab OAuth2 clients."""
+    """Adapter for GitHub OAuth2 clients."""
 
     @property
     def authorization_url(self) -> str:
@@ -94,6 +94,9 @@ def token_endpoint_url(self) -> str:
     def api_url(self) -> str:
         """The URL used for API calls on the Resource Server."""
         url = urlparse(self.client_url)
+        # See: https://docs.github.com/en/apps/sharing-github-apps/making-your-github-app-available-for-github-enterprise-server#the-app-code-must-use-the-correct-urls
+        if url.netloc != "github.com":
+            return urljoin(self.client_url, "api/v3/")
         url = url._replace(netloc=f"api.{url.netloc}")
         return urlunparse(url)
 

components/renku_data_services/repositories/provider_adapters.py

@@ -73,12 +73,15 @@ def api_validate_repository_response(
 
 
 class GitHubAdapter(GitProviderAdapter):
-    """Adapter for GitLab OAuth2 clients."""
+    """Adapter for GitHub OAuth2 clients."""
 
     @property
     def api_url(self) -> str:
         """The URL used for API calls on the Resource Server."""
         url = urlparse(self.client_url)
+        # See: https://docs.github.com/en/apps/sharing-github-apps/making-your-github-app-available-for-github-enterprise-server#the-app-code-must-use-the-correct-urls
+        if url.netloc != "github.com":
+            return urljoin(self.client_url, "api/v3/")
         url = url._replace(netloc=f"api.{url.netloc}")
         return urlunparse(url)