chore: fix tests

Author: olevski

.devcontainer/devcontainer.json

@@ -34,7 +34,7 @@
 		"ghcr.io/devcontainers-contrib/features/poetry",
 		"ghcr.io/devcontainers-contrib/features/bash-command"
 	],
-	"postCreateCommand": "poetry install --with dev",
+	"postCreateCommand": "poetry install --with dev && mkdir -p /home/vscode/.config/k9s",
 	"customizations": {
 		"vscode": {
 			"extensions": [

.devcontainer/docker-compose.yml

@@ -25,6 +25,7 @@ services:
       POETRY_CACHE_DIR: "/poetry_cache"
       NB_SERVER_OPTIONS__DEFAULTS_PATH: /workspace/server_defaults.json
       NB_SERVER_OPTIONS__UI_CHOICES_PATH: /workspace/server_options.json
+      KUBECONFIG: "/workspace/.k3d-config.yaml"
     network_mode: service:db
     depends_on:
       - db

.gitignore

@@ -79,3 +79,5 @@ docker-compose.override.yml
 # nix
 result
 *.qcow2
+
+.k3d-config.yaml

components/renku_data_services/notebooks/api/classes/image.py

@@ -30,7 +30,9 @@ class ImageRepoDockerAPI:
     hostname: str
     oauth2_token: Optional[str] = field(default=None, repr=False)
     # NOTE: We need to follow redirects so that we can authenticate with the image repositories properly.
-    client: httpx.AsyncClient = httpx.AsyncClient(timeout=10, follow_redirects=True)
+    # NOTE: If we do not use default_factory to create the client here requests will fail beause it can happen
+    # that the client gets created in the wrong asyncio loop.
+    client: httpx.AsyncClient = field(default_factory=lambda: httpx.AsyncClient(timeout=10, follow_redirects=True))
 
     async def _get_docker_token(self, image: "Image") -> Optional[str]:
         """Get an authorization token from the docker v2 API.

pyproject.toml

@@ -150,7 +150,7 @@ ignore = [
 "components/renku_data_services/notebooks/crs.py" = ["F401"]
 
 [tool.ruff.lint.isort]
-known-first-party = ["renku_data_services"]
+known-first-party = ["renku_data_services", "test"]
 
 [tool.ruff.lint.pydocstyle]
 convention = "google"

test/bases/renku_data_services/data_api/test_notebooks.py

@@ -3,7 +3,7 @@
 import asyncio
 import os
 import shutil
-from collections.abc import AsyncIterator
+from collections.abc import AsyncIterator, Iterator
 from unittest.mock import MagicMock
 from uuid import uuid4
 
@@ -13,14 +13,12 @@
 from sanic_testing.testing import SanicASGITestClient
 
 from renku_data_services.notebooks.api.classes.k8s_client import JupyterServerV1Alpha1Kr8s
-
-from .utils import K3DCluster, setup_amalthea
-
-os.environ["KUBECONFIG"] = ".k3d-config.yaml"
+from test.bases.renku_data_services.data_api.utils import K3DCluster, setup_amalthea
 
 
 @pytest.fixture(scope="module", autouse=True)
-def cluster() -> K3DCluster:
+def cluster() -> Iterator[K3DCluster]:
+    os.environ["KUBECONFIG"] = ".k3d-config.yaml"
     if shutil.which("k3d") is None:
         pytest.skip("Requires k3d for cluster creation")
 

test/bases/renku_data_services/data_api/test_sessions.py

@@ -13,14 +13,12 @@
 from renku_data_services.app_config.config import Config
 from renku_data_services.crc.apispec import ResourcePool
 from renku_data_services.users.models import UserInfo
-
-from .utils import K3DCluster, setup_amalthea
-
-os.environ["KUBECONFIG"] = ".k3d-config.yaml"
+from test.bases.renku_data_services.data_api.utils import K3DCluster, setup_amalthea
 
 
 @pytest.fixture(scope="module")
 def cluster() -> Iterator[K3DCluster]:
+    os.environ["KUBECONFIG"] = ".k3d-config.yaml"
     if shutil.which("k3d") is None:
         pytest.skip("Requires k3d for cluster creation")