use patch

Author: leafty

components/renku_data_services/data_connectors/blueprints.py

@@ -282,14 +282,14 @@ async def _get_secrets(
 
         return "/data_connectors/<data_connector_id:ulid>/secrets", ["GET"], _get_secrets
 
-    def put_secrets(self) -> BlueprintFactoryResponse:
-        """Create or update saved secrets for a data connector."""
+    def patch_secrets(self) -> BlueprintFactoryResponse:
+        """Create, update or delete saved secrets for a data connector."""
 
         @authenticate(self.authenticator)
         @only_authenticated
         @validate_body_root_model(json=apispec.DataConnectorSecretPatchList)
-        async def _put_secrets(
-            request: Request,
+        async def _patch_secrets(
+            _: Request,
             user: base_models.APIUser,
             data_connector_id: ULID,
             body: apispec.DataConnectorSecretPatchList,
@@ -302,7 +302,7 @@ async def _put_secrets(
                 apispec.DataConnectorSecretsList, [self._dump_data_connector_secret(secret) for secret in secrets]
             )
 
-        return "/data_connectors/<data_connector_id:ulid>/secrets", ["PUT"], _put_secrets
+        return "/data_connectors/<data_connector_id:ulid>/secrets", ["PATCH"], _patch_secrets
 
     def delete_secrets(self) -> BlueprintFactoryResponse:
         """Delete all saved secrets for a data connector."""

test/bases/renku_data_services/data_api/test_data_connectors.py

@@ -1023,7 +1023,7 @@ async def test_patch_data_connector_secrets(
         {"name": "access_key_id", "value": "access key id value"},
         {"name": "secret_access_key", "value": "secret access key value"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
 
@@ -1052,7 +1052,7 @@ async def test_patch_data_connector_secrets_update_secrets(
         {"name": "access_key_id", "value": "access key id value"},
         {"name": "secret_access_key", "value": "secret access key value"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
     assert response.status_code == 200, response.json
@@ -1066,7 +1066,7 @@ async def test_patch_data_connector_secrets_update_secrets(
         {"name": "access_key_id", "value": "new access key id value"},
         {"name": "secret_access_key", "value": "new secret access key value"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
 
@@ -1097,7 +1097,7 @@ async def test_patch_data_connector_secrets_add_and_remove_secrets(
         {"name": "access_key_id", "value": "access key id value"},
         {"name": "secret_access_key", "value": "secret access key value"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
     assert response.status_code == 200, response.json
@@ -1112,7 +1112,7 @@ async def test_patch_data_connector_secrets_add_and_remove_secrets(
         {"name": "secret_access_key", "value": None},
         {"name": "password", "value": "password"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
 
@@ -1151,7 +1151,7 @@ async def test_delete_data_connector_secrets(
         {"name": "access_key_id", "value": "access key id value"},
         {"name": "secret_access_key", "value": "secret access key value"},
     ]
-    _, response = await sanic_client.put(
+    _, response = await sanic_client.patch(
         f"/api/data/data_connectors/{data_connector_id}/secrets", headers=user_headers, json=payload
     )
     assert response.status_code == 200, response.json