Skip to content

Commit 9c064c0

Browse files
committed
feat: run notebooks in data service (#375)
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> squashme: resolve package version conflicts
1 parent a45bec2 commit 9c064c0

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

  • components/renku_data_services/notebooks/api/classes

components/renku_data_services/notebooks/api/classes/k8s_client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -487,10 +487,9 @@ async def delete_server(self, server_name: str, safe_username: str) -> None:
487487
"""Delete the server."""
488488
server = await self.get_server(server_name, safe_username)
489489
if not server:
490-
raise MissingResourceError(
491-
f"Cannot find server {server_name} for user " f"{safe_username} in order to delete it."
492-
)
493-
return await self.renku_ns_client.delete_server(server_name)
490+
return None
491+
await self.renku_ns_client.delete_server(server_name)
492+
return None
494493

495494
async def patch_tokens(self, server_name: str, renku_tokens: RenkuTokens, gitlab_token: GitlabToken) -> None:
496495
"""Patch the Renku and Gitlab access tokens used in a session."""

0 commit comments

Comments
 (0)