Skip to content

Commit a0c85dc

Browse files
authored
fix: update ports for the git proxy (#938)
Closes #921.
1 parent 06157f0 commit a0c85dc

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

components/renku_data_services/notebooks/api/amalthea_patches/init_containers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ async def git_clone_container_v2(
9393
},
9494
]
9595
if user.is_authenticated:
96+
env.append({"name": f"{prefix}GIT_PROXY_PORT", "value": str(config.sessions.git_proxy.port)})
9697
if user.email:
9798
env.append(
9899
{"name": f"{prefix}USER__EMAIL", "value": user.email},

components/renku_data_services/notebooks/config/dynamic.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ def from_env(cls) -> Self:
108108
class _GitProxyConfig:
109109
renku_client_secret: str = field(repr=False)
110110
sentry: _SentryConfig = field(default_factory=_SentryConfig.from_env)
111-
port: int = 8080
112-
health_port: int = 8081
111+
port: int = 65480
112+
health_port: int = 65481
113113
image: str = f"renku/git-https-proxy:{latest_version}"
114114
renku_client_id: str = "renku"
115115

@@ -119,8 +119,8 @@ def from_env(cls) -> Self:
119119
renku_client_secret=os.environ["NB_SESSIONS__GIT_PROXY__RENKU_CLIENT_SECRET"],
120120
renku_client_id=os.environ.get("NB_SESSIONS__GIT_PROXY__RENKU_CLIENT_ID", "renku"),
121121
sentry=_SentryConfig.from_env(prefix="NB_SESSIONS__GIT_PROXY__"),
122-
port=_parse_value_as_int(os.environ.get("NB_SESSIONS__GIT_PROXY__PORT", 8080)),
123-
health_port=_parse_value_as_int(os.environ.get("NB_SESSIONS__GIT_PROXY__HEALTH_PORT", 8081)),
122+
port=_parse_value_as_int(os.environ.get("NB_SESSIONS__GIT_PROXY__PORT", 65480)),
123+
health_port=_parse_value_as_int(os.environ.get("NB_SESSIONS__GIT_PROXY__HEALTH_PORT", 65481)),
124124
image=os.environ.get("NB_SESSIONS__GIT_PROXY__IMAGE", f"renku/git-https-proxy:{latest_version}"),
125125
)
126126

0 commit comments

Comments
 (0)