feat: allow v1 sessions to be disabled (#983)

Closes #982.

Author: leafty

components/renku_data_services/notebooks/config/__init__.py

@@ -134,6 +134,7 @@ class NotebooksConfig:
         default_factory=_ServersGetEndpointAnnotations
     )
     session_id_cookie_name: str = "_renku_session"  # NOTE: This cookie name is set and controlled by the gateway
+    v1_sessions_enabled: bool = False
 
     @classmethod
     def from_env(cls, db_config: DBConfig) -> Self:
@@ -148,6 +149,7 @@ def from_env(cls, db_config: DBConfig) -> Self:
         git_provider_helper: GitProviderHelperProto
         k8s_namespace = os.environ.get("K8S_NAMESPACE", "default")
         kube_config_root = os.environ.get("K8S_CONFIGS_ROOT", "/secrets/kube_configs")
+        v1_sessions_enabled = _parse_str_as_bool(os.environ.get("V1_SESSIONS_ENABLED", False))
 
         if dummy_stores:
             quota_repo = QuotaRepository(DummyCoreClient({}, {}), DummySchedulingClient({}), namespace=k8s_namespace)
@@ -220,4 +222,5 @@ def from_env(cls, db_config: DBConfig) -> Self:
             k8s_db_cache=k8s_db_cache,
             cluster_rp=cluster_rp,
             _kr8s_api=kr8s_api,
+            v1_sessions_enabled=v1_sessions_enabled,
         )

components/renku_data_services/notebooks/core.py

@@ -339,6 +339,9 @@ async def launch_notebook_helper(
     if server:
         return UserServerManifest(server, nb_config.sessions.default_image, nb_config.sessions.storage.pvs_enabled), 200
 
+    if not nb_config.v1_sessions_enabled:
+        raise errors.ForbiddenError(message="Starting v1 sessions is not allowed.")
+
     gl_project_path = gl_project_path if gl_project_path is not None else ""
 
     # Add annotation for old and new notebooks

test/conftest.py

@@ -219,6 +219,7 @@ async def app_manager(
     monkeysession.setenv("MAX_PINNED_PROJECTS", "5")
     monkeysession.setenv("NB_SERVER_OPTIONS__DEFAULTS_PATH", "server_defaults.json")
     monkeysession.setenv("NB_SERVER_OPTIONS__UI_CHOICES_PATH", "server_options.json")
+    monkeysession.setenv("V1_SESSIONS_ENABLED", "true")
 
     dm = TestDependencyManager.from_env(dummy_users)