squashme: minor fix

Author: olevski

components/renku_data_services/session/db.py

@@ -402,7 +402,7 @@ async def update_launcher(
                     launcher.environment = new_env
                 else:
                     # Fields on the environment attached to the launcher are being changed.
-                    for key, val in env_payload:
+                    for key, val in env_payload.items():
                         # NOTE: Only some fields can be updated.
                         if key in [
                             "name",
@@ -415,7 +415,7 @@ async def update_launcher(
                             "uid",
                             "gid",
                         ]:
-                            setattr(launcher.environment, key, value)
+                            setattr(launcher.environment, key, val)
 
             return launcher.dump()
 

test/bases/renku_data_services/data_api/test_sessions.py

@@ -462,3 +462,13 @@ async def test_patch_session_launcher_environment(
         f"/api/data/session_launchers/{launcher_id}", headers=user_headers, json=patch_payload
     )
     assert res.status_code == 200, res.text
+
+    # Should be able to patch some fields of the custom environment
+    patch_payload = {
+        "environment": {"container_image": "nginx:latest"},
+    }
+    _, res = await sanic_client.patch(
+        f"/api/data/session_launchers/{launcher_id}", headers=user_headers, json=patch_payload
+    )
+    assert res.status_code == 200, res.text
+    assert res.json["environment"]["container_image"] == "nginx:latest"