Skip to content

fix: k8s watcher crashes when amalthea session has no label #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mohammad-alisafaee wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: k8s watcher crashes when amalthea session has no label #1170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/renku_data_services/k8s/watcher/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ def __init__(
async def __sync(self, client: K8sClusterClient, kind: GVK, raise_exceptions: bool = False) -> None:
"""Upsert K8s objects in the cache and remove deleted objects from the cache."""

fltr = K8sObjectFilter(gvk=kind, cluster=client.get_cluster().id, namespace=client.get_cluster().namespace)
filter = K8sObjectFilter(gvk=kind, cluster=client.get_cluster().id, namespace=client.get_cluster().namespace)
# Upsert new / updated objects
objects_in_k8s: dict[str, K8sObject] = {}
obj_iter = aiter(client.list(fltr))
obj_iter = aiter(client.list(filter))
while True:
try:
obj = await anext(obj_iter)
Expand All @@ -67,7 +67,7 @@ async def __sync(self, client: K8sClusterClient, kind: GVK, raise_exceptions: bo
objects_in_k8s[obj.name] = obj
await self.__cache.upsert(obj)

cache_iter = aiter(self.__cache.list(fltr))
cache_iter = aiter(self.__cache.list(filter))
while True:
try:
cache_obj = await anext(cache_iter)
Expand Down
Loading