Draft
Conversation
Coverage Report for CI Build 24514809140Coverage decreased (-1.1%) to 86.39%Details
Uncovered Changes
Coverage Regressions331 previously-covered lines in 16 files lost coverage.
Coverage Stats
💛 - Coveralls |
rokroskar
force-pushed
the
000-add-metadata-to-resumed-session-metrics
branch
from
a7c1e1a to
044cffd
Compare
also ensures that resumed sessions use the resource requests matching current resource class configuration.
rokroskar
force-pushed
the
000-add-metadata-to-resumed-session-metrics
branch
3 times, most recently
from
b881f8b to
cdd7adc
Compare
rokroskar
force-pushed
the
000-add-metadata-to-resumed-session-metrics
branch
from
cdd7adc to
31b2539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more metadata about the resource request to
user_requested_session_resumeandsession_resumedmetrics. The reason being that the resource request could have changed while thesession_idstayed the same, leading to incorrect metrics.To ensure consistency with expectations of admins who manage resource pools and classes, the PR also makes a change to ensure that resumed sessions use the resource requests matching current resource class configuration.