feat: add DELETE /apps endpoint#1336
Merged
Merged
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1336.dev.renku.ch |
olevski
requested changes
Jun 4, 2026
olevski
left a comment
Member
There was a problem hiding this comment.
This looks good Wes. I will come back to it when it is fully ready.
Comment on lines
+72
to
+81
| async def delete_app(self, user: base_models.APIUser, app_name: str) -> None: | ||
| """Delete an app by its name.""" | ||
| if not user.is_authenticated or user.id is None: | ||
| raise errors.UnauthorizedError(message="You do not have the required permissions for this operation.") | ||
|
|
||
| runtime_state = await self.k8s_client.get_app_deployment(app_name) | ||
| if runtime_state is None: | ||
| logger.info(f"App with name {app_name} was not found.") | ||
| return None | ||
|
|
Member
There was a problem hiding this comment.
You are missing the authorization check.
Suggested change
| async def delete_app(self, user: base_models.APIUser, app_name: str) -> None: | |
| """Delete an app by its name.""" | |
| if not user.is_authenticated or user.id is None: | |
| raise errors.UnauthorizedError(message="You do not have the required permissions for this operation.") | |
| runtime_state = await self.k8s_client.get_app_deployment(app_name) | |
| if runtime_state is None: | |
| logger.info(f"App with name {app_name} was not found.") | |
| return None | |
| async def delete_app(self, user: base_models.APIUser, app_name: str) -> None: | |
| """Delete an app by its name.""" | |
| if not user.is_authenticated or user.id is None: | |
| raise errors.UnauthorizedError(message="You do not have the required permissions for this operation.") | |
| authorized = await self.authz.has_permission(user, ResourceType.project, launcher.project_id, Scope.WRITE) | |
| if not authorized: | |
| raise errors.MissingResourceError( | |
| message=f"Project with id '{launcher.project_id}' does not exist or you do not have access to it." | |
| ) | |
| runtime_state = await self.k8s_client.get_app_deployment(app_name) | |
| if runtime_state is None: | |
| logger.info(f"App with name {app_name} was not found.") | |
| return None | |
olevski
approved these changes
Jun 15, 2026
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/deploy