-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add DELETE /apps endpoint #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bdf3c6b
api spec and models
wesjdj 57358b5
add knative servive crd pydantic types
wesjdj b197e1f
reshape api spec for /apps endpoints
wesjdj 081b4f6
fix quantity types and collapse models
wesjdj fb608f8
add k8s client
wesjdj 85ad1ee
add knative service converter and make url optional
wesjdj f5b5b5c
make url nullable
wesjdj 83e5521
add /apps POST and GET endpoints
wesjdj 84c8a3e
fix: bundle renku_apps component in data_service wheel
wesjdj 5256b3e
get apps kantive manifest from session launcher
wesjdj b49d236
derive app URL from project path
wesjdj 7c3481e
get URL from knative status. name services per project
wesjdj 7af9966
cache KnativeService GVK
wesjdj b8627b7
add dummy renku apps user id
wesjdj 1310765
subscribe k8s watcher to Knative Services
wesjdj 858b4ff
bundle renku_apps component in k8s_watcher
wesjdj 814be8f
keep K8s types out of core.py and repository
wesjdj 3b2dbcf
restore oci_schema target
wesjdj 651da95
address PR review comments
wesjdj 65ca6ec
add delete to api spec
wesjdj 6c6be10
add delete app function to repository
wesjdj 73e7473
add delete apps endpoint
wesjdj ea0d84d
use injected cluster_id in delete_app_deployment
wesjdj 20777fc
Merge branch 'add-apps-feature' into add-apps-delete
wesjdj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the authorization check.