[REBASE only]: Migrate notebooks and add new amalthea#418
Merged
Conversation
30923b5 to
a45bec2
Compare
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-418.dev.renku.ch |
7fcfa17 to
be5272b
Compare
be5272b to
b1932ee
Compare
b1932ee to
fd2e56c
Compare
Member
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Oct 4, 2024
fd2e56c to
df3bb88
Compare
3070da0 to
d2b2d48
Compare
d2b2d48 to
a932966
Compare
This was causing the API to consider some images as non-existing. Whereas in reality they exist. I noticed this with this image: ghcr.io/salimkayal/renku-devcontainer-wizard:latest.
The move of business logic out of the blueprint allows the code to be reusable without having to go through the web API. It also allows for tests to be added without the web complexity. Tests have been refactored so that test clusters will be created only when testing endpoints that actually require a cluster. This has the advantage of speeding up test time. This is especially useful when doing development. Finally, a new test option has been added so one can use a local cluster in place of re-creating one each time tests are run.
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch> Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch> Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
36a3e19 to
36e290d
Compare
leafty
previously approved these changes
Nov 11, 2024
36e290d to
2fd571e
Compare
Member
|
There is a test failing because of this -> #525. |
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
2fd571e to
1046f40
Compare
Member
Author
I saw that I just used a tagged image in the test which passes the tests for now. I dont want to mess with the image checks further here. |
leafty
approved these changes
Nov 11, 2024
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines all changes for the notebooks migration and new amalthea operator.
NOTE: This should be rebased on main. DO NOT SQUASH AND MERGE. WHEN updating this branch remember to REABASE only too.
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=main renku-ui=andrea/jupyter-free-build renku-gateway=master extra-values=amalthea-sessions.deployCrd=false