From a97cb59560fdc7464cc837a18fd796d9a1da4a20 Mon Sep 17 00:00:00 2001 From: Flora Thiebaut Date: Mon, 1 Dec 2025 13:48:59 +0100 Subject: [PATCH 1/3] build: update linter --- .github/workflows/test.yaml | 2 +- Makefile | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 5336a0f..61c306e 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -62,4 +62,4 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v9 with: - version: v2.1 + version: v2.6 diff --git a/Makefile b/Makefile index d332fcc..d2fa16e 100644 --- a/Makefile +++ b/Makefile @@ -69,6 +69,10 @@ check-format: ## Check that sources are correctly formatted check-vet: ## Check source files with `go vet` go vet ./... +.PHONY: lint +lint: ## Lint source files with `golangci-lint run` + golangci-lint run + ##@ Code generation .PHONY: renku-users-apispec @@ -80,8 +84,6 @@ renku-users-apispec: ## Download the "users" API spec .PHONY: renku-session-apispec renku-session-apispec: ## Download the "session" API spec curl -L -o pkg/renkuapi/session/api.spec.yaml https://raw.githubusercontent.com/SwissDataScienceCenter/renku-data-services/refs/heads/main/components/renku_data_services/session/api.spec.yaml - # sed -e 's/- default: "general"//g' pkg/renkuapi/users/api.spec.yaml > pkg/renkuapi/users/api.spec.new.yaml - # mv pkg/renkuapi/users/api.spec.new.yaml pkg/renkuapi/users/api.spec.yaml .PHONY: generate generate: pkg/renkuapi/users/users_gen.go pkg/renkuapi/session/session_gen.go ## Run go generate From a3ef379f02887e45abdee46625bdd261a46f32b1 Mon Sep 17 00:00:00 2001 From: Flora Thiebaut Date: Mon, 1 Dec 2025 13:52:39 +0100 Subject: [PATCH 2/3] add doc for golangci-lint --- DEVELOPING.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 DEVELOPING.md diff --git a/DEVELOPING.md b/DEVELOPING.md new file mode 100644 index 0000000..ef94577 --- /dev/null +++ b/DEVELOPING.md @@ -0,0 +1,4 @@ +## Linting + +Developers need to manually install `golangci-lint`. +See: https://golangci-lint.run/docs/welcome/install/. From b458d5b685986b02f9a3eb72946cb7b8b4625ec2 Mon Sep 17 00:00:00 2001 From: Flora Thiebaut Date: Mon, 1 Dec 2025 13:55:33 +0100 Subject: [PATCH 3/3] update --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 61c306e..0a645c9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -59,7 +59,7 @@ jobs: run: | sudo apt install libx11-dev - - name: golangci-lint + - name: Run golangci-lint uses: golangci/golangci-lint-action@v9 with: version: v2.6