feat: allow to toggle off v1 services#770
Merged
Merged
Conversation
olevski
requested changes
Jul 16, 2025
olevski
left a comment
olevski
left a comment
Member
There was a problem hiding this comment.
Thanks Flora this looks really nice.
olevski
previously approved these changes
Jul 16, 2025
leafty
commented
Jul 16, 2025
leafty
commented
Jul 16, 2025
olevski
approved these changes
Jul 16, 2025
Member
Author
|
Thanks @olevski , I would like to first update the v2 acceptance tests to work without GItLab first before merging here (so that we should be sure that everything works fine). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
revproxy.enableV1Servicesandlogin.enableV1Servicesconfiguration fields/api,/api/direct, etc. -> GitLab/api/kg, etc. -> KG, webhook/ui-server/*routes related to v1 features/api/search(service is not deployed anymore)Corresponding renku PR -> SwissDataScienceCenter/renku#4094
Renku PR without GitLab -> SwissDataScienceCenter/renku#4096 (same as above but with v1 de-activated)