Skip to content

feat: enable build from private repositories#4133

Open
sgaist wants to merge 7 commits intomainfrom
feat/build-private-repositories
Open

feat: enable build from private repositories#4133
sgaist wants to merge 7 commits intomainfrom
feat/build-private-repositories

Conversation

@sgaist
Copy link
Copy Markdown
Collaborator

@sgaist sgaist commented Apr 15, 2026

Describe your changes

Users who have pull access to a repository can now use them for building custom images.

The UI changes reflect the new possibility but is likely lacking information to the users such as using a different registry to store the resulting image.

Links and tickets

Depends on SwissDataScienceCenter/renku-data-services#1250
Should be merged after SwissDataScienceCenter/renku#4428 is done

@sgaist sgaist requested a review from a team as a code owner April 15, 2026 14:37
@sgaist sgaist force-pushed the feat/build-private-repositories branch from 2dce23e to 2395635 Compare April 15, 2026 14:38
Copy link
Copy Markdown
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How do we convey to the user that the image is going to be public or private?
  2. I don't think the resulting image is usable at the moment, so do we wait until using a private image from harbor is working?

@sgaist
Copy link
Copy Markdown
Collaborator Author

sgaist commented Apr 16, 2026

@leafty

  1. Good point, I think this should be discussed more thoroughly with our designer friends. My main goal with this initial implementation was to make it possible to use the feature from the UI and not just through the API.
  2. This indeed requires feat: add configuration for building images from private repositories renku#4428 to be merged first.

I'll check and fix the conflict over there and fix the description here.

Users who have pull access to a repository can now use
them for building custom images.
@sgaist sgaist force-pushed the feat/build-private-repositories branch from 2395635 to f12d0fa Compare April 16, 2026 09:29
@sgaist
Copy link
Copy Markdown
Collaborator Author

sgaist commented Apr 22, 2026

Beside the renku PR listed above, SwissDataScienceCenter/renku-data-services#1265 is required for sessions to be able to pull the image.

@sgaist sgaist requested a review from leafty April 24, 2026 14:47
Copy link
Copy Markdown
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offcanvas information needs to be updated, and the badge on the session launcher as well.

Image

@sgaist
Copy link
Copy Markdown
Collaborator Author

sgaist commented Apr 29, 2026

@leafty I think this particular issue comes from the backend not the UI.

The API to check session images does not handle the private build part yet.

@leafty
Copy link
Copy Markdown
Member

leafty commented Apr 29, 2026

@leafty I think this particular issue comes from the backend not the UI.

The API to check session images does not handle the private build part yet.

Yes, but if the image is not accessible (because the user does not have permissions), then this message is still not correct for images built from a private repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants