Open
Conversation
2dce23e to
2395635
Compare
leafty
reviewed
Apr 16, 2026
Member
leafty
left a comment
There was a problem hiding this comment.
- How do we convey to the user that the image is going to be public or private?
- I don't think the resulting image is usable at the moment, so do we wait until using a private image from harbor is working?
Collaborator
Author
I'll check and fix the conflict over there and fix the description here. |
Users who have pull access to a repository can now use them for building custom images.
2395635 to
f12d0fa
Compare
Collaborator
Author
|
Beside the renku PR listed above, SwissDataScienceCenter/renku-data-services#1265 is required for sessions to be able to pull the image. |
This will inform people that the resulting image will be sent to a different registry.
Collaborator
Author
|
@leafty I think this particular issue comes from the backend not the UI. The API to check session images does not handle the private build part yet. |
Member
Yes, but if the image is not accessible (because the user does not have permissions), then this message is still not correct for images built from a private repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Describe your changes
Users who have pull access to a repository can now use them for building custom images.
The UI changes reflect the new possibility but is likely lacking information to the users such as using a different registry to store the resulting image.
Links and tickets
Depends on SwissDataScienceCenter/renku-data-services#1250
Should be merged after SwissDataScienceCenter/renku#4428 is done