feat: update renku-gateway to 1.6.0 (#4094)

leafty · web-flow · commit 515a773f3eaf · 2025-07-22T12:48:04.000+02:00
The gateway can now run without GitLab when `enableV1Services` is set to `false`.

The cypress acceptance tests are updated to support correctly running when `enableV1Services=false`.
diff --git a/cypress-tests/cypress/e2e/checkWorkflows.cy.ts b/cypress-tests/cypress/e2e/checkWorkflows.cy.ts
@@ -15,7 +15,7 @@ describe("Workflows pages", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/privateProject.cy.ts b/cypress-tests/cypress/e2e/privateProject.cy.ts
@@ -34,7 +34,7 @@ describe("Basic public project functionality", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/publicProject.cy.ts b/cypress-tests/cypress/e2e/publicProject.cy.ts
@@ -35,7 +35,7 @@ describe("Basic public project functionality", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/rstudioSession.cy.ts b/cypress-tests/cypress/e2e/rstudioSession.cy.ts
@@ -36,7 +36,7 @@ describe("Basic rstudio functionality", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/testDatasets.cy.ts b/cypress-tests/cypress/e2e/testDatasets.cy.ts
@@ -30,7 +30,7 @@ describe("Basic datasets functionality", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/updateProjects.cy.ts b/cypress-tests/cypress/e2e/updateProjects.cy.ts
@@ -26,7 +26,7 @@ describe("Fork and update old projects", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v1");
       },
       validateLogin,
     );
diff --git a/cypress-tests/cypress/e2e/useSession.cy.ts b/cypress-tests/cypress/e2e/useSession.cy.ts
@@ -191,7 +191,7 @@ describe("Basic public project functionality", () => {
     // Stop the session -- mind that anonymous users cannot pause sessions
     cy.deleteSession({ fromSessionPage: true });
 
-    cy.robustLogin();
+    cy.robustLogin("v1");
   });
 
   it("Start a new session on a project without permissions.", () => {
diff --git a/cypress-tests/cypress/e2e/v2/anonymousNavigation.cy.ts b/cypress-tests/cypress/e2e/v2/anonymousNavigation.cy.ts
@@ -21,7 +21,7 @@ const loggedSession = {
   id: ["anonymousNavigation-loggedUser", getRandomString()],
   setup: () => {
     cy.log("Logged in session");
-    cy.robustLogin();
+    cy.robustLogin("v2");
   },
 };
 
diff --git a/cypress-tests/cypress/e2e/v2/dashboardV2.cy.ts b/cypress-tests/cypress/e2e/v2/dashboardV2.cy.ts
@@ -1,4 +1,4 @@
-import { getRandomString, validateLogin } from "../../support/commands/general";
+import { getRandomString, validateLoginV2 } from "../../support/commands/general";
 import { generatorProjectName } from "../../support/commands/projects";
 import { ProjectIdentifierV2 } from "../../support/types/project.types";
 import {
@@ -39,9 +39,9 @@ describe("Dashboard v2 - Authenticated user", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
-      validateLogin,
+      validateLoginV2,
     );
     getUserNamespaceAPIV2().then((namespace) => {
       if (namespace) {
diff --git a/cypress-tests/cypress/e2e/v2/groupBasics.cy.ts b/cypress-tests/cypress/e2e/v2/groupBasics.cy.ts
@@ -27,7 +27,7 @@ describe("Group - create, edit and delete", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
diff --git a/cypress-tests/cypress/e2e/v2/projectBasics.cy.ts b/cypress-tests/cypress/e2e/v2/projectBasics.cy.ts
@@ -36,7 +36,7 @@ describe("Project - create, edit and delete", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
diff --git a/cypress-tests/cypress/e2e/v2/projectResources.cy.ts b/cypress-tests/cypress/e2e/v2/projectResources.cy.ts
@@ -31,7 +31,7 @@ describe("Project resources - work with code, data, environments", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
@@ -54,7 +54,7 @@ describe("Project resources - work with code, data, environments", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
diff --git a/cypress-tests/cypress/e2e/v2/searchEntities.cy.ts b/cypress-tests/cypress/e2e/v2/searchEntities.cy.ts
@@ -44,7 +44,7 @@ describe("Search for resources: groups, projects, users", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
@@ -84,7 +84,7 @@ describe("Search for resources: groups, projects, users", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
diff --git a/cypress-tests/cypress/e2e/v2/sessionBasics.cy.ts b/cypress-tests/cypress/e2e/v2/sessionBasics.cy.ts
@@ -39,7 +39,7 @@ describe("Start a session that consumes project resources", () => {
     cy.session(
       sessionId,
       () => {
-        cy.robustLogin();
+        cy.robustLogin("v2");
       },
       validateLoginV2,
     );
diff --git a/cypress-tests/cypress/support/commands/login.ts b/cypress-tests/cypress/support/commands/login.ts
@@ -76,7 +76,7 @@ type RegisterAndVerifyProps = {
   lastName?: string;
 };
 
-function registerAndVerify(props: RegisterAndVerifyProps) {
+function registerAndVerify(renkuVersion : 'v1' | 'v2', props: RegisterAndVerifyProps) {
   // Register with the CI deployment
   const { email, password, firstName, lastName } = props;
   cy.register(email, password, firstName, lastName);
@@ -107,25 +107,27 @@ function registerAndVerify(props: RegisterAndVerifyProps) {
   // allow Gitlab to "settle" after the login and properly recognize the token and respond with 200.
   // eslint-disable-next-line cypress/no-unnecessary-waiting
   cy.wait(TIMEOUTS.short);
-  cy.request("ui-server/api/data/user").its("status").should("eq", 200);
-  cy.request("ui-server/api/user").then((response) => {
+  cy.request("/api/data/user").its("status").should("eq", 200);
+  if (renkuVersion === 'v1') {
+  cy.request("/api/user").then((response) => {
     expect(response.status).to.eq(200);
     expect(response.body).property("username").to.not.be.empty;
     expect(response.body).property("username").to.not.be.null;
     expect(response.body).property("state").to.equal("active");
-  });
+  });}
 }
 
 type RobustLoginProps = {
   email: string;
   password: string;
   firstName?: string;
   lastName?: string;
+  
 };
 
-function robustLogin(props?: RobustLoginProps) {
+function robustLogin(renkuVersion: 'v1' | 'v2',props?: RobustLoginProps) {
   // Check if we are already logged in
-  cy.request({ failOnStatusCode: false, url: "ui-server/api/data/user" }).then(
+  cy.request({ failOnStatusCode: false, url: "/api/data/user" }).then(
     (resp) => {
       // we are already logged in
       if (resp.status >= 200 && resp.status < 400) return;
@@ -139,7 +141,7 @@ function robustLogin(props?: RobustLoginProps) {
         ...props,
       };
 
-      return registerAndVerify(localProps);
+      return registerAndVerify(renkuVersion, localProps);
     },
   );
 }
@@ -162,8 +164,8 @@ declare global {
         firstName?: string,
         lastName?: string,
       );
-      registerAndVerify(props: RegisterAndVerifyProps);
-      robustLogin(props?: RobustLoginProps);
+      registerAndVerify(renkuVersion: 'v1' | 'v2', props: RegisterAndVerifyProps);
+      robustLogin(renkuVersion: 'v1' | 'v2', props?: RobustLoginProps);
     }
   }
 }
diff --git a/helm-chart/renku/templates/gateway/configmap.yaml b/helm-chart/renku/templates/gateway/configmap.yaml
@@ -36,6 +36,7 @@ data:
           audience: renku
           authorizedParty: renku-cli
     revproxy:
+      enableV1Services: {{ .Values.enableV1Services | default false }}
       renkuBaseUrl: {{ include "renku.baseUrl" . | quote }}
       externalGitlabUrl: {{ .Values.global.gitlab.url | default "" | quote }}
       k8sNamespace: {{ .Release.Namespace }}
@@ -54,6 +55,7 @@ data:
         uiserver: {{ printf "http://%s" (include "ui-server.fullname" .) | quote }} 
         search: {{ printf "http://%s-search-api" .Release.Name | quote }}
     login:
+      enableV1Services: {{ .Values.enableV1Services | default false }}
       renkuBaseUrl: {{ include "renku.baseUrl" . | quote }}
       loginRoutesBasePath: "/api/auth"
       defaultAppRedirectURL: {{ include "renku.baseUrl" . | quote }}
@@ -66,12 +68,14 @@ data:
           scopes: ["profile", "email", "openid", "microprofile-jwt"]
           callbackURI:  {{ printf "%s/api/auth/callback" (include "renku.baseUrl" .) }}
           usePKCE: false
+        {{- if .Values.enableV1Services }}
         gitlab:
           issuer: {{ .Values.global.gitlab.url | quote }}
           clientID: {{ .Values.gateway.gitlabClientId | default .Values.global.gateway.gitlabClientId | quote }}
           scopes: ["openid", "api", "read_user", "read_repository"] 
           callbackURI: {{ printf "%s/api/auth/callback" (include "renku.baseUrl" .) }}
           usePKCE: false
+        {{- end }}
       oldGitLabLogout: {{ .Values.gateway.oldGitLabLogout | default false }}
       logoutGitLabUponRenkuLogout: {{ .Values.gateway.logoutGitLabUponRenkuLogout | default true }}
     redis:
diff --git a/helm-chart/renku/templates/gateway/deployment-revproxy.yaml b/helm-chart/renku/templates/gateway/deployment-revproxy.yaml
@@ -71,11 +71,13 @@ spec:
                 secretKeyRef:
                   name: {{ cat (include "renku.fullname" .) "-gateway" | nospace }}
                   key: oidcClientSecret
+            {{- if .Values.enableV1Services }}
             - name: GATEWAY_LOGIN_PROVIDERS_GITLAB_CLIENTSECRET
               valueFrom:
                 secretKeyRef:
                   name: {{ cat (include "renku.fullname" .) "-gateway" | nospace }}
                   key: gitlabClientSecret
+            {{- end }}
             - name: GATEWAY_LOGIN_TOKENENCRYPTION_SECRETKEY
               valueFrom:
                 secretKeyRef:
@@ -91,6 +93,7 @@ spec:
                 secretKeyRef:
                   name: {{ cat (include "renku.fullname" .) "-gateway" | nospace }}
                   key: cookieHashKey
+            {{- if .Values.enableV1Services }}
             - name: GATEWAY_LOGIN_PROVIDERS_GITLAB_COOKIEENCODINGKEY
               valueFrom:
                 secretKeyRef:
@@ -101,6 +104,7 @@ spec:
                 secretKeyRef:
                   name: {{ cat (include "renku.fullname" .) "-gateway" | nospace }}
                   key: cookieHashKey
+            {{- end }}
             - name: GATEWAY_MONITORING_SENTRY_DSN
               value: {{ .Values.gateway.sentry.dsn }}
             - name: GATEWAY_POSTHOG_ENABLED
diff --git a/helm-chart/renku/templates/ui/ui-client-deployment-template.yaml b/helm-chart/renku/templates/ui/ui-client-deployment-template.yaml
@@ -88,7 +88,7 @@ spec:
                   key: chart_version
             - name: HOMEPAGE
               value: {{ toJson .Values.ui.client.homepage | quote }}
-            - name: CORE_API_VERSION_CONFIG			
+            - name: CORE_API_VERSION_CONFIG
               value: {{ toJson .Values.ui.client.coreApiVersionConfig | quote }}
             - name: KEYCLOAK_REALM
               value: {{ include "renku.keycloak.realm" . | quote }}
@@ -98,6 +98,8 @@ spec:
               value: {{ toJson .Values.ui.client.sessionClassEmailUs | quote }}
             - name: IMAGE_BUILDERS_ENABLED
               value: {{ .Values.dataService.imageBuilders.enabled | quote }}
+            - name: LEGACY_SUPPORT
+              value: {{ printf "{\"enabled\": %t }" .Values.enableV1Services | quote }}
           livenessProbe:
             httpGet:
               path: /
diff --git a/helm-chart/renku/values.yaml b/helm-chart/renku/values.yaml
@@ -1148,7 +1148,7 @@ gateway:
   secretKey:
   image:
     repository: renku/renku-gateway
-    tag: "1.5.1"
+    tag: "1.6.0"
     pullPolicy: IfNotPresent
   service:
     type: ClusterIP
