Skip to content

Commit ccb7234

Browse files
RenkuBotlorenzo-cavazziolevskidependabot[bot]rokroskar
authored
release 0.65.0 (#3872)
* chore: create release 0.65.0 * chore(ci): update renku actions to v1.14.0 (#3886) Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> * fix: update csi rclone to 0.3.6 (#3889) * chore(deps-dev): bump braces from 3.0.2 to 3.0.3 in /cypress-tests (#3888) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /cypress-tests (#3840) Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rok Roškar <roskarr@ethz.ch> Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> * Merge branch 'master' into release-0.65.0 (#3895) * feat(helm): Make Jena passwords optional in values file. This commit continues on the topic of making the definition of the secrets in the values files optional, to simplify CI deployments. As previous similar commits this change supports: - Existing deployments where the secret is defined will keep working as usual - New deployments where the secret is defined will keep working as they did before this change - New deployments where the secret is NOT defined will get 2 random passwords which will be persisted across upgrades/redeployments The three scenarios have been manually tested. * feat: Make Redis and OIDC client secrets optional. These are the last two secrets that were needed to be generated out-of-bands before deploying Renkulab. Thus the `generate-values` script is not really necessary anymore and in its place there is a `minimal-deployment` values file that in a future commit will also be used as a base for CI deployments. The documentation has been updated to reflect the removal of the script. Further cleanup and simplification of the Helm chart will result in a smaller and simpler minimum-deployment file, with the ultimate goal of being able to issue `helm install renku/renku` resulting in a functioning development deployment. * feat: Define some more sensible defaults. * feat: Configure data-services to connect to solr (#3918) * chore(ci): update renku actions to v1.14.1 (#3927) Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> * chore: update renku-ui to 3.47.0 (#3930) * revert: Configure data services to connect to solr Refs: e831264 * tests: add cypress tests for Renku 2.0 (#3879) * Add prettier and update linter configuration * Fix setting up baseUrl when running on cli * Test project basic operations: create, edit, delete (#3881, #3908) * Test working on groups: create, edit, delete (#3883, #3908) * Test project resources -- code, data, environments (#3894) * Test search entities (#3904) * Test anonymous users navigation (#3906) * Test running sessions (#3912) * Update the cypress tests readme file (#3884) * Split v2 and legacy cypress tests, improve naming (#3926) --------- Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> Co-authored-by: Rok Roškar <roskarr@ethz.ch> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com> Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rok Roškar <roskarr@ethz.ch> Co-authored-by: Alessandro Degano <a.degano@gmail.com> Co-authored-by: eikek <701128+eikek@users.noreply.github.com> Co-authored-by: Chandrasekhar Ramakrishnan <ciyer@users.noreply.github.com> Co-authored-by: Tasko Olevski <olevski90@gmail.com>
1 parent ea4029b commit ccb7234

58 files changed

Lines changed: 1695 additions & 726 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/cron-jobs.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-22.04
1212
steps:
1313
- name: renku teardown
14-
uses: SwissDataScienceCenter/renku-actions/cleanup-renku-ci-deployments@v1.14.0
14+
uses: SwissDataScienceCenter/renku-actions/cleanup-renku-ci-deployments@v1.14.1
1515
env:
1616
GITLAB_TOKEN: ${{ secrets.DEV_GITLAB_TOKEN }}
1717
RENKUBOT_KUBECONFIG: ${{ secrets.RENKUBOT_DEV_KUBECONFIG }}

‎.github/workflows/generate-values-script.yaml‎

Lines changed: 0 additions & 63 deletions
This file was deleted.

‎.github/workflows/publish-helm-chart.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Set version
1616
id: vars
1717
run: echo "tag=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT
18-
- uses: SwissDataScienceCenter/renku-actions/publish-chart@v1.14.0
18+
- uses: SwissDataScienceCenter/renku-actions/publish-chart@v1.14.1
1919
env:
2020
CHART_DIR: helm-chart/
2121
CHART_NAME: renku

‎.github/workflows/publish-master-merges.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- id: set-version
3636
run: |
3737
echo "publish_version=${{ steps.bump-semver.outputs.new_version }}.$(echo ${{ github.sha }} | cut -c 1-7)" >> $GITHUB_ENV
38-
- uses: SwissDataScienceCenter/renku-actions/publish-chart@v1.14.0
38+
- uses: SwissDataScienceCenter/renku-actions/publish-chart@v1.14.1
3939
env:
4040
CHART_DIR: helm-chart/
4141
CHART_TAG: "--tag ${{env.publish_version}}"

‎.github/workflows/pull-request-test.yml‎

Lines changed: 40 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Deploy and Test PR
1+
name: Test PR
22
on:
33
pull_request:
44
types:
@@ -15,6 +15,7 @@ concurrency:
1515

1616
jobs:
1717
test-docs:
18+
name: Documentation
1819
if: github.event.action != 'closed'
1920
runs-on: ubuntu-latest
2021
steps:
@@ -48,6 +49,7 @@ jobs:
4849
path: docs/_build/html/
4950

5051
check-deploy:
52+
name: Analyze deploy string
5153
runs-on: ubuntu-22.04
5254
outputs:
5355
pr-contains-string: ${{ steps.deploy-comment.outputs.pr-contains-string }}
@@ -64,12 +66,13 @@ jobs:
6466
steps:
6567
- uses: actions/checkout@v4.1.7
6668
- id: deploy-comment
67-
uses: SwissDataScienceCenter/renku-actions/check-pr-description@v1.14.0
69+
uses: SwissDataScienceCenter/renku-actions/check-pr-description@v1.14.1
6870
with:
6971
string: /deploy
7072
pr_ref: ${{ github.event.number }}
7173

7274
deploy-pr:
75+
name: Deploy
7376
if: github.event.action != 'closed'
7477
needs: [check-deploy]
7578
runs-on: ubuntu-22.04
@@ -80,7 +83,7 @@ jobs:
8083
- uses: actions/checkout@v4.1.7
8184
- name: renku build and deploy
8285
if: needs.check-deploy.outputs.pr-contains-string == 'true'
83-
uses: SwissDataScienceCenter/renku-actions/deploy-renku@v1.14.0
86+
uses: SwissDataScienceCenter/renku-actions/deploy-renku@v1.14.1
8487
env:
8588
DOCKER_PASSWORD: ${{ secrets.RENKU_DOCKER_PASSWORD }}
8689
DOCKER_USERNAME: ${{ secrets.RENKU_DOCKER_USERNAME }}
@@ -120,11 +123,12 @@ jobs:
120123
You can access the deployment of this PR at https://ci-renku-${{ github.event.number }}.dev.renku.ch
121124
122125
test-pr:
126+
name: Legacy Scala tests
123127
if: github.event.action != 'closed' && needs.check-deploy.outputs.pr-contains-string == 'true' && needs.check-deploy.outputs.test-enabled == 'true'
124128
needs: [check-deploy, deploy-pr]
125129
runs-on: ubuntu-22.04
126130
steps:
127-
- uses: SwissDataScienceCenter/renku-actions/test-renku@v1.14.0
131+
- uses: SwissDataScienceCenter/renku-actions/test-renku@v1.14.1
128132
with:
129133
kubeconfig: ${{ secrets.RENKUBOT_DEV_KUBECONFIG }}
130134
renku-release: ci-renku-${{ github.event.number }}
@@ -133,7 +137,8 @@ jobs:
133137
s3-results-secret-key: ${{ secrets.ACCEPTANCE_TESTS_BUCKET_SECRET_KEY }}
134138
test-timeout-mins: "120"
135139

136-
test-pr-cypress:
140+
legacy-cypress-acceptance-tests:
141+
name: Legacy Cypress tests
137142
needs: [check-deploy, deploy-pr]
138143
runs-on: ubuntu-22.04
139144

@@ -149,19 +154,45 @@ jobs:
149154
useSession,
150155
checkWorkflows,
151156
rstudioSession,
152-
dashboardV2,
153157
]
158+
steps:
159+
- uses: SwissDataScienceCenter/renku-actions/test-renku-cypress@v1.14.1
160+
if: github.event.action != 'closed' && needs.check-deploy.outputs.pr-contains-string == 'true' && needs.check-deploy.outputs.test-enabled == 'true'
161+
with:
162+
e2e-target: ${{ matrix.tests }}
163+
renku-reference: ${{ github.ref }}
164+
renku-release: ci-renku-${{ github.event.number }}
165+
test-user-password: ${{ secrets.RENKU_BOT_DEV_PASSWORD }}
154166

167+
cypress-acceptance-tests:
168+
name: Cypress tests
169+
needs: [check-deploy, deploy-pr]
170+
runs-on: ubuntu-22.04
171+
strategy:
172+
fail-fast: false
173+
matrix:
174+
tests:
175+
[
176+
anonymousNavigation,
177+
dashboardV2,
178+
groupBasics,
179+
projectBasics,
180+
projectResources,
181+
searchEntities,
182+
sessionBasics,
183+
]
155184
steps:
156185
- uses: SwissDataScienceCenter/renku-actions/test-renku-cypress@v1.14.0
157186
if: github.event.action != 'closed' && needs.check-deploy.outputs.pr-contains-string == 'true' && needs.check-deploy.outputs.test-enabled == 'true'
158187
with:
188+
e2e-folder: cypress/e2e/v2/
159189
e2e-target: ${{ matrix.tests }}
160190
renku-reference: ${{ github.ref }}
161191
renku-release: ci-renku-${{ github.event.number }}
162192
test-user-password: ${{ secrets.RENKU_BOT_DEV_PASSWORD }}
193+
163194
deploy-string-no-custom-version:
164-
name: Check that deploy string doesn't specify a custom component version
195+
name: Ensure no custom components
165196
needs: [check-deploy]
166197
runs-on: ubuntu-22.04
167198
steps:
@@ -182,11 +213,12 @@ jobs:
182213
with:
183214
script: core.setFailed('Cannot merge release PR if it still has custom versions in deploy string.')
184215
cleanup:
216+
name: Cleanup
185217
if: github.event.action == 'closed'
186218
runs-on: ubuntu-22.04
187219
steps:
188220
- name: renku teardown
189-
uses: SwissDataScienceCenter/renku-actions/cleanup-renku-ci-deployments@v1.14.0
221+
uses: SwissDataScienceCenter/renku-actions/cleanup-renku-ci-deployments@v1.14.1
190222
env:
191223
HELM_RELEASE_REGEX: "^ci-renku-${{ github.event.number }}$"
192224
GITLAB_TOKEN: ${{ secrets.DEV_GITLAB_TOKEN }}

‎.github/workflows/renku-dev-test.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
github.event.client_payload.message == 'Helm test succeeded' }}
99
runs-on: ubuntu-20.04
1010
steps:
11-
- uses: SwissDataScienceCenter/renku-actions/test-renku@v1.14.0
11+
- uses: SwissDataScienceCenter/renku-actions/test-renku@v1.14.1
1212
with:
1313
kubeconfig: ${{ secrets.RENKUBOT_DEV_KUBECONFIG }}
1414
renku-release: renku

‎CHANGELOG.rst‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,38 @@
11
.. _changelog:
22

3+
0.65.0
4+
------
5+
6+
User-Facing Changes
7+
~~~~~~~~~~~~~~~~~~~
8+
9+
**🌟 New Features**
10+
11+
- **UI**: Projects can now have documentation. (`#3478 <https://github.com/SwissDataScienceCenter/renku-ui/pull/3478>`__).
12+
13+
Internal Changes
14+
~~~~~~~~~~~~~~~~
15+
16+
**Improvements**
17+
18+
- **Jena**: Now the passwords for the admin and Renku Jena users are optional to define in the values file: if the
19+
secret defining them already exists, it will be maintained, if it does not a set of random passwords will
20+
be generated.
21+
22+
- **Redis**: Now the password for Redis is optional to define in the values file: if the secret defining it already
23+
exists, it will be maintained, if it does not a set of random passwords will be generated.
24+
25+
- **OIDC**: Now all OIDC secrets are optional to define in the values file: if the secret defining them already exists,
26+
it will be maintained, if it does not a set of random passwords will be generated.
27+
28+
- Values for `notebooks.oidc.authUrl`, `notebooks.oidc.tokenUrl`, `notebooks.sessionIngress` have now sensible defaults
29+
and are optional to define in the values file if Keycloak is deployed through the Renku Helm chart.
30+
31+
Individual Components
32+
~~~~~~~~~~~~~~~~~~~~~
33+
34+
- `renku-ui 3.47.0 <https://github.com/SwissDataScienceCenter/renku-ui/releases/tag/3.47.0>`_
35+
336
0.64.3
437
------
538

‎cypress-tests/.eslintrc.json‎

Lines changed: 14 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -5,69 +5,35 @@
55
"project": "tsconfig.json",
66
"sourceType": "module"
77
},
8-
"plugins": [
9-
"@typescript-eslint",
10-
"cypress"
11-
],
8+
"plugins": ["@typescript-eslint", "cypress", "no-only-tests"],
129
"rules": {
13-
"max-len": ["warn", 120],
1410
"no-eval": "error",
15-
"quotes": ["warn", "double", {
16-
"allowTemplateLiterals": true,
17-
"avoidEscape": true
18-
}],
19-
"@typescript-eslint/no-unused-vars": ["warn", {
20-
"vars": "all",
21-
"args": "none",
22-
"ignoreRestSiblings": false,
23-
"argsIgnorePattern": "^_",
24-
"varsIgnorePattern": "^_"
25-
}],
11+
"no-unused-vars": [
12+
"warn",
13+
{
14+
"vars": "all",
15+
"args": "none",
16+
"ignoreRestSiblings": false
17+
}
18+
],
2619
"no-console": "warn",
27-
"curly": ["warn", "multi-or-nest", "consistent"],
28-
"indent": ["warn", 2, {
29-
"ignoredNodes": ["TemplateLiteral"],
30-
"SwitchCase": 1
31-
}],
32-
"semi": ["warn", "always"],
33-
"space-before-blocks": ["warn", "always"],
34-
"no-multi-spaces": "warn",
35-
"brace-style": ["warn", "stroustrup", {
36-
"allowSingleLine": true
37-
}],
38-
"max-nested-callbacks": ["warn", 3],
20+
"max-nested-callbacks": ["warn", 4],
3921
"no-alert": "error",
4022
"no-else-return": "warn",
4123
"jest/expect-expect": "off",
42-
"comma-spacing": "warn",
43-
"block-spacing": ["warn", "always"],
44-
"key-spacing": "warn",
45-
"no-trailing-spaces": "warn",
46-
"object-curly-spacing": ["warn", "always"],
47-
"space-infix-ops": "warn",
48-
"space-unary-ops": ["warn", {
49-
"words": true,
50-
"nonwords": false
51-
}],
52-
"keyword-spacing": ["warn", {
53-
"before": true
54-
}],
55-
"no-multiple-empty-lines": ["warn", {
56-
"max": 2,
57-
"maxEOF": 1
58-
}],
59-
"eol-last": 1,
6024
"cypress/no-assigning-return-values": "error",
6125
"cypress/no-unnecessary-waiting": "error",
6226
"cypress/assertion-before-screenshot": "warn",
6327
"cypress/no-force": "warn",
6428
"cypress/no-async-tests": "error",
65-
"cypress/no-pause": "error"
29+
"cypress/no-pause": "error",
30+
"no-only-tests/no-only-tests": "error"
6631
},
6732
"extends": [
6833
"eslint:recommended",
6934
"plugin:@typescript-eslint/eslint-recommended",
7035
"plugin:@typescript-eslint/recommended",
71-
"plugin:cypress/recommended"
36+
"plugin:cypress/recommended",
37+
"prettier"
7238
]
7339
}

0 commit comments

Comments
 (0)