Skip to content

chore: allow CI deployments on Azure#3981

Merged
wesjdj merged 2 commits intomasterfrom
deploy_ci_on_Azure2
Apr 23, 2025
Merged

chore: allow CI deployments on Azure#3981
wesjdj merged 2 commits intomasterfrom
deploy_ci_on_Azure2

Conversation

@wesjdj
Copy link
Copy Markdown
Contributor

@wesjdj wesjdj commented Apr 11, 2025 •
edited by lorenzo-cavazzi
Loading

Deploy to the Azure Dev cluster by using the (slash)AzureDeploy string

/AzureDeploy #legacy

@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 11, 2025 08:09 — with GitHub Actions Inactive
@RenkuBot
Copy link
Copy Markdown
Collaborator

RenkuBot commented Apr 11, 2025

You can access the deployment of this PR at https://ci-renku-3981.dev.azure.renku.ch

@wesjdj wesjdj changed the title WIP: allow CI deployments on Azure chore: allow CI deployments on Azure Apr 11, 2025
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 11, 2025 09:31 — with GitHub Actions Inactive
@wesjdj wesjdj marked this pull request as ready for review April 11, 2025 09:31
@wesjdj wesjdj requested a review from a team as a code owner April 11, 2025 09:31
lorenzo-cavazzi
lorenzo-cavazzi reviewed Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic comment: Why make a separate workflow? A bunch of jobs overlap with the existing pull-request-test workflow. We can adapt it to have an additional deploy-pr-azure job

olevski
olevski requested changes Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion. And I think Lorenzo did the review at the same time as me.

Comment thread .github/workflows/pull-request-test-azure.yml Outdated
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 11, 2025 13:44 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 09:29 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 09:32 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 09:42 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 09:52 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:08 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:26 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:28 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:36 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:46 — with GitHub Actions Inactive
@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from 0eb7e66 to 10e85a9 Compare April 14, 2025 11:54
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 14, 2025 11:54 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 08:18 — with GitHub Actions Inactive
@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from 0bc1ec0 to 809da18 Compare April 15, 2025 08:35
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 08:56 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 08:59 — with GitHub Actions Inactive
@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from 5b26a74 to 69e912b Compare April 15, 2025 09:00
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 09:00 — with GitHub Actions Inactive
@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from 69e912b to 659426d Compare April 15, 2025 09:01
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 09:02 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 11:31 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 15, 2025 12:28 — with GitHub Actions Inactive
@wesjdj wesjdj requested a review from olevski April 15, 2025 12:28
lorenzo-cavazzi
lorenzo-cavazzi previously requested changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already 👏
I added a couple of nitpick comments, feel free to ignore them.

I added the deploy string and something seems off with #legacy, the tests didn't run

Comment thread .github/workflows/pull-request-test.yml Outdated
Comment thread .github/workflows/pull-request-test.yml
Comment thread .github/workflows/pull-request-test.yml
@wesjdj
Copy link
Copy Markdown
Contributor Author

wesjdj commented Apr 16, 2025 •
edited
Loading

Looks good already 👏 I added a couple of nitpick comments, feel free to ignore them.

I added the deploy string and something seems off with #legacy, the tests didn't run

There is an issue on the cluster with csi-rclone, hence some sessions are not able to start

@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from 06e99d2 to 3fc96bd Compare April 16, 2025 12:30
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 16, 2025 12:31 — with GitHub Actions Inactive
@wesjdj wesjdj requested a review from lorenzo-cavazzi April 16, 2025 13:43
@lorenzo-cavazzi
Copy link
Copy Markdown
Member

lorenzo-cavazzi commented Apr 17, 2025

Looks good already 👏 I added a couple of nitpick comments, feel free to ignore them.
I added the deploy string and something seems off with #legacy, the tests didn't run

There is an issue on the cluster with csi-rclone, hence some sessions are not able to start

Shouldn't the check still show up? I'm surprised to see that the job was skipped even with the #legacy option in the deploy string.

image

Also, this hasn't been addressed #3981 (comment)
Let's be consistent in the version we use for renku-actions.

@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from b2101b9 to 2266829 Compare April 22, 2025 07:37
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 07:37 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 08:11 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 08:56 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 09:03 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 09:40 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 11:08 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 11:17 — with GitHub Actions Inactive
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 12:08 — with GitHub Actions Inactive
@wesjdj wesjdj force-pushed the deploy_ci_on_Azure2 branch from e4a9f33 to 3a8ec5d Compare April 22, 2025 12:27
@wesjdj wesjdj temporarily deployed to ci-renku-3981 April 22, 2025 12:27 — with GitHub Actions Inactive
@wesjdj wesjdj dismissed lorenzo-cavazzi’s stale review April 23, 2025 07:34

Approved by Tasko, issues addressed

@wesjdj wesjdj merged commit 9e0140d into master Apr 23, 2025
26 checks passed
@wesjdj wesjdj deleted the deploy_ci_on_Azure2 branch April 23, 2025 08:05
@RenkuBot
Copy link
Copy Markdown
Collaborator

RenkuBot commented Apr 23, 2025

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olevski olevski olevski approved these changes

@lorenzo-cavazzi lorenzo-cavazzi Awaiting requested review from lorenzo-cavazzi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wesjdj @RenkuBot @lorenzo-cavazzi @olevski @rokroskar