test: update data connector tests to support new linking#4431
Open
lorenzo-cavazzi wants to merge 3 commits intorelease-2.17.0from
Open
test: update data connector tests to support new linking#4431lorenzo-cavazzi wants to merge 3 commits intorelease-2.17.0from
lorenzo-cavazzi wants to merge 3 commits intorelease-2.17.0from
Conversation
Collaborator
|
You can access the deployment of this PR at https://ci-renku-4431.dev.renku.ch |
Member
|
@lorenzo-cavazzi release 2.16.0 was merged please move to #4434 |
lorenzo-cavazzi
force-pushed
the
lorenzo/data-connector-modal
branch
from
c7db2b2 to
9f2075b
Compare
Member
Author
Ok 👍 |
leafty
reviewed
Apr 22, 2026
| visibility: "private", | ||
| }).then((response) => { | ||
| projectId = response.body.id; | ||
| projectId = response.body.id ?? ""; |
Member
There was a problem hiding this comment.
why? If the response is not typed, maybe add types.
Member
Author
There was a problem hiding this comment.
lorenzo-cavazzi
force-pushed
the
lorenzo/data-connector-modal
branch
from
f6c2ecb to
61437eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update data connectors tests to support the new search modal when linking/adding data connectors
/deploy