Skip to content

fix: Allow config of WebOrigins & RedirectUris #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sambuc merged 3 commits into from
Apr 30, 2026
+24 −2
Merged

fix: Allow config of WebOrigins & RedirectUris #4444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12399b5
fix: Allow config of WebOrigins & RedirectUris
sambuc Apr 27, 2026
9939214
fix: By default, explicitly set an empty list
sambuc Apr 27, 2026
7d48440
fix: Add a comment about the format of the value
sambuc Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm-chart/renku/templates/setup-job-keycloak-realms.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ spec:
value: "false"
- name: NOTEBOOKS_KC_CLIENT_OAUTH_FLOW
value: "authorization_code"
- name: NOTEBOOKS_KC_CLIENT_EXTRA_REDIRECT_URIS
value: {{ .Values.notebooks.oidc.extraRedirectUris | quote }}
- name: NOTEBOOKS_KC_CLIENT_EXTRA_WEB_ORIGINS
value: {{ .Values.notebooks.oidc.extraWebOrigins | quote }}
- name: SWAGGER_KC_CLIENT_ID
value: swagger
- name: SWAGGER_KC_CLIENT_PUBLIC
Expand Down
10 changes: 10 additions & 0 deletions helm-chart/renku/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,16 @@ notebooks:
tokenUrl:
authUrl:
allowUnverifiedEmail: false
## This value is a yaml string of a json list of URIs strings, i.e.
## '["https://domain-a.example.org/*", "https://domain-b.example.net/*"]'
## Each URI should follow the format expected by Keycloak in the Redirect
## URIs field of a keycloak client.
extraRedirectUris: '[]'
## This value is a yaml string of a json list of URIs strings, i.e.
## '["https://domain-a.example.org/*", "https://domain-b.example.net/*"]'
## Each URI should follow the format expected by Keycloak in the Web Origins
## field of a keycloak client.
extraWebOrigins: '[]'
sessionIngress:
host:
## If you want to use the default cluster tls cert, set the flag below to true.
Expand Down
12 changes: 10 additions & 2 deletions scripts/init-realm/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ class OIDCClient:
service_account_roles: List[str] = field(default_factory=list)
service_account_realm_roles: List[str] = field(default_factory=list)
public_client: bool = False
client_extra_web_origins: List[str] = field(default_factory=list)
client_extra_redirect_uris: List[str] = field(default_factory=list)

def __post_init__(self):
self.base_url = self.base_url.rstrip("/")
Expand Down Expand Up @@ -163,8 +165,8 @@ def to_dict(self) -> Dict[str, Any]:
"baseUrl": self.base_url,
"publicClient": self.public_client,
"attributes": self.attributes,
"redirectUris": [self.base_url + "/*"],
"webOrigins": [self.base_url + "/*"],
"redirectUris": [self.base_url + "/*"] + self.client_extra_redirect_uris,
"webOrigins": [self.base_url + "/*"] + self.client_extra_web_origins,
"protocolMappers": default_protocol_mappers
+ [
{
Expand Down Expand Up @@ -207,6 +209,12 @@ def from_env(cls, prefix: str = "RENKU_KC_CLIENT_") -> "OIDCClient":
service_account_realm_roles=json.loads(
os.environ.get(f"{prefix}SERVICE_ACCOUNT_REALM_ROLES", "[]")
),
client_extra_redirect_uris=json.loads(
os.environ.get(f"{prefix}EXTRA_REDIRECT_URIS", "[]")
),
client_extra_web_origins=json.loads(
os.environ.get(f"{prefix}EXTRA_WEB_ORIGINS", "[]")
)
)


Expand Down
Loading