Skip to content

Improve log when secret is not found in keyVault#173

Merged
RohrerF merged 2 commits into
mainfrom
rflo/improve-secret-not-found
Apr 10, 2025
Merged

Improve log when secret is not found in keyVault#173
RohrerF merged 2 commits into
mainfrom
rflo/improve-secret-not-found

Conversation

@RohrerF

@RohrerF RohrerF commented Apr 10, 2025

Copy link
Copy Markdown
Member

This pull request introduces improvements to error handling and logging when interacting with Azure Key Vault. The changes primarily focus on providing more detailed error messages by including the path of the secret that caused the error.

Improvements to error handling:

Updates to method signatures:

Enhancements to Azure Key Vault provider:

@RohrerF RohrerF requested review from Carael and Copilot April 10, 2025 13:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Confix.Tool/src/Confix.Library/Utilities/Azure/KeyVaultExtension.cs:9

  • [nitpick] Consider renaming the parameter 'path' to 'secretPath' for clearer intent that it represents the secret's key path.
public static async Task<T> HandleKeyVaultException<T>(Func<Task<T>> action, string? path = null)

@RohrerF RohrerF removed the request for review from Carael April 10, 2025 13:26
@RohrerF RohrerF merged commit 5f4ecc0 into main Apr 10, 2025
@RohrerF RohrerF deleted the rflo/improve-secret-not-found branch April 10, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants