fix: enhance Skip() method to prevent infinite loops during deserialization of nested mappings#6
Conversation
…zation of nested mappings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a critical bug in the YAML deserialization logic that could cause infinite loops or out-of-memory errors when skipping unknown properties, especially those containing nested mappings or sibling discriminators with unknown values. The fix ensures that the reader correctly advances past skipped content, and comprehensive tests are added to verify correct behavior in these scenarios.
Key changes:
Bug Fixes & Reader Logic
Skip()method inUtf8YamlReaderto always advance the reader past the end of skipped nested mappings and end markers, preventing infinite loops when unknown or unexpected tokens are encountered. This also includes clarifying documentation forSkip(). [1] [2]Source Generator Updates
nullwhen needed. [1] [2]Test Coverage
Added a comprehensive suite of regression tests to cover scenarios with unknown properties (including deeply nested mappings), sibling discriminators with unknown values, and lists with mixed known/unknown discriminator values. These tests verify that deserialization does not hang and that subsequent properties are parsed correctly.
Registered new types in the test serialization context to support the new tests for nested mappings and sibling discriminators.