fix: enhance custom converter handling to skip empty checks and improve serialization logic#8
Merged
Merged
Conversation
…ve serialization logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of custom converters in the YAML serialization framework, particularly around delegation to generated code and the interaction with the
IgnoreEmptyObjectsoption. It strengthens the contract for generated read/write delegates, ensures correct serialization behavior for custom converters with nested nullable objects, and adds comprehensive tests for these scenarios.Custom Converter Contract Improvements
GeneratedReadandGeneratedWriteproperties inYamlConverter<T>are now non-nullable and throw clear exceptions if accessed before initialization, making the contract for custom converters more robust and developer-friendly. [1] [2] [3]GeneratedReadandGeneratedWritein custom converters and documentation to remove null-forgiving operators, reflecting the new non-nullable contract. [1] [2]Source Generator Logic
IsEmptychecks for types with custom converters, ensuring that custom converters have full control over serialization logic and are not affected by empty-object optimizations.Testing and Validation
IgnoreEmptyObjectsis enabled: properties with custom converters are always written (unless null), and round-tripping preserves data as expected. [1] [2]