Skip to content

Commit c07ae8c

Browse files
committed
Refactor BewitTokenExtractionMiddlewareTests; add logging support to middleware instantiation for improved debugging
1 parent 843f85c commit c07ae8c

1 file changed

Lines changed: 18 additions & 8 deletions

File tree

test/Extensions.HotChocolate.Tests/BewitTokenExtractionMiddlewareTests.cs

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
using FluentAssertions;
22
using Microsoft.AspNetCore.Http;
3+
using Microsoft.Extensions.Logging;
4+
using Microsoft.Extensions.Logging.Abstractions;
35
using Microsoft.Extensions.Options;
46
using Microsoft.Extensions.Primitives;
57
using Xunit;
@@ -32,7 +34,8 @@ public async Task InvokeAsync_WithHeaderToken_ShouldSetContextItem()
3234

3335
return Task.CompletedTask;
3436
},
35-
CreateOptions());
37+
CreateOptions(),
38+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
3639

3740
await middleware.InvokeAsync(context);
3841

@@ -48,7 +51,8 @@ public async Task InvokeAsync_WithQueryParam_ShouldSetContextItem()
4851

4952
var middleware = new BewitTokenExtractionMiddleware(
5053
_ => Task.CompletedTask,
51-
CreateOptions());
54+
CreateOptions(),
55+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
5256

5357
await middleware.InvokeAsync(context);
5458

@@ -64,7 +68,8 @@ public async Task InvokeAsync_WithHeaderAndQueryParam_ShouldPreferHeader()
6468

6569
var middleware = new BewitTokenExtractionMiddleware(
6670
_ => Task.CompletedTask,
67-
CreateOptions());
71+
CreateOptions(),
72+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
6873

6974
await middleware.InvokeAsync(context);
7075

@@ -78,7 +83,8 @@ public async Task InvokeAsync_WithNoToken_ShouldNotSetContextItem()
7883

7984
var middleware = new BewitTokenExtractionMiddleware(
8085
_ => Task.CompletedTask,
81-
CreateOptions());
86+
CreateOptions(),
87+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
8288

8389
await middleware.InvokeAsync(context);
8490

@@ -94,7 +100,8 @@ public async Task InvokeAsync_WithEmptyHeader_ShouldFallbackToQueryParam()
94100

95101
var middleware = new BewitTokenExtractionMiddleware(
96102
_ => Task.CompletedTask,
97-
CreateOptions());
103+
CreateOptions(),
104+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
98105

99106
await middleware.InvokeAsync(context);
100107

@@ -109,7 +116,8 @@ public async Task InvokeAsync_WithCustomHeaderName_ShouldReadFromCustomHeader()
109116

110117
var middleware = new BewitTokenExtractionMiddleware(
111118
_ => Task.CompletedTask,
112-
CreateOptions(o => o.HeaderName = "X-My-Token"));
119+
CreateOptions(o => o.HeaderName = "X-My-Token"),
120+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
113121

114122
await middleware.InvokeAsync(context);
115123

@@ -124,7 +132,8 @@ public async Task InvokeAsync_WithCustomQueryParamName_ShouldReadFromCustomParam
124132

125133
var middleware = new BewitTokenExtractionMiddleware(
126134
_ => Task.CompletedTask,
127-
CreateOptions(o => o.QueryParamName = "token"));
135+
CreateOptions(o => o.QueryParamName = "token"),
136+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
128137

129138
await middleware.InvokeAsync(context);
130139

@@ -144,7 +153,8 @@ public async Task InvokeAsync_ShouldAlwaysCallNext()
144153

145154
return Task.CompletedTask;
146155
},
147-
CreateOptions());
156+
CreateOptions(),
157+
NullLogger<BewitTokenExtractionMiddleware>.Instance);
148158

149159
await middleware.InvokeAsync(context);
150160

0 commit comments

Comments
 (0)