fix(web): delete draft events immediately#1881
Merged
Merged
Conversation
tyler-dane
force-pushed
the
fix/delete-alert
branch
2 times, most recently
from
0345c70 to
e0ec11c
Compare
tyler-dane
force-pushed
the
fix/delete-alert
branch
from
e0ec11c to
0d4890a
Compare
tyler-dane
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Draft events in the EventForm now close immediately when deleted, instead of flowing through the confirmation alert. The delete hotkey and the action menu both share the same draft-aware delete path.
Why
Drafts are unsaved state. They should discard directly rather than asking for a confirmation that only applies to persisted events.
Impact
Deleting a draft event now behaves like a discard action, which removes an unnecessary confirmation step and matches the user expectation for unsaved work.
Validation
TZ=Etc/UTC bun run type-check:web-testsTZ=Etc/UTC bun run test:webTZ=Etc/UTC bun run lintCloses #1879