Skip to content

Commit 72d19ea

Browse files
committed
Refactor permit method to use splat operator for attribute names
1 parent e668363 commit 72d19ea

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

lib/structured_params/params.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,20 +94,20 @@ def permit_attribute_names
9494
# For Form Objects (with require):
9595
# UserRegistrationForm.permit(params)
9696
# # equivalent to:
97-
# params.require(:user_registration).permit(UserRegistrationForm.permit_attribute_names)
97+
# params.require(:user_registration).permit(*UserRegistrationForm.permit_attribute_names)
9898
#
9999
# For API requests (without require):
100100
# UserParams.permit(params, require: false)
101101
# # equivalent to:
102-
# params.permit(UserParams.permit_attribute_names)
102+
# params.permit(*UserParams.permit_attribute_names)
103103
#
104104
#: (ActionController::Parameters params, ?require: bool) -> ActionController::Parameters
105105
def permit(params, require: true)
106106
if require
107107
key = model_name.param_key.to_sym
108-
params.require(key).permit(permit_attribute_names)
108+
params.require(key).permit(*permit_attribute_names)
109109
else
110-
params.permit(permit_attribute_names)
110+
params.permit(*permit_attribute_names)
111111
end
112112
end
113113

sig/structured_params/params.rbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ module StructuredParams
7777
# For Form Objects (with require):
7878
# UserRegistrationForm.permit(params)
7979
# # equivalent to:
80-
# params.require(:user_registration).permit(UserRegistrationForm.permit_attribute_names)
80+
# params.require(:user_registration).permit(*UserRegistrationForm.permit_attribute_names)
8181
#
8282
# For API requests (without require):
8383
# UserParams.permit(params, require: false)
8484
# # equivalent to:
85-
# params.permit(UserParams.permit_attribute_names)
85+
# params.permit(*UserParams.permit_attribute_names)
8686
#
8787
# : (ActionController::Parameters params, ?require: bool) -> ActionController::Parameters
8888
def self.permit: (ActionController::Parameters params, ?require: bool) -> ActionController::Parameters

0 commit comments

Comments
 (0)