Skip to content

Commit 76c906f

Browse files
committed
Refactor README to clarify usage of UserParams and UserRegistrationForm
1 parent d1b1248 commit 76c906f

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ end
5454

5555
# Use in API controller
5656
def create
57-
permitted = UserParams.permit(params, require: false)
58-
user_params = UserParams.new(permitted)
57+
user_params = UserParams.new(params)
5958

6059
if user_params.valid?
6160
User.create!(user_params.attributes)
@@ -92,6 +91,8 @@ class UserRegistrationForm < StructuredParams::Params
9291
end
9392

9493
# Use in controller
94+
# permit calls params.require(:user_registration).permit(...) internally.
95+
# Unlike API usage, form objects need require to scope to the correct key.
9596
def create
9697
form = UserRegistrationForm.new(UserRegistrationForm.permit(params))
9798

README_ja.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ end
5454

5555
# API コントローラーで使用
5656
def create
57-
permitted = UserParams.permit(params, require: false)
58-
user_params = UserParams.new(permitted)
57+
user_params = UserParams.new(params)
5958

6059
if user_params.valid?
6160
User.create!(user_params.attributes)
@@ -91,6 +90,8 @@ class UserRegistrationForm < StructuredParams::Params
9190
end
9291

9392
# コントローラーで使用
93+
# permit は params.require(:user_registration).permit(...) を内部で呼び出す
94+
# API と異なり、フォームオブジェクトでは require によるキー絞り込みが必要なため permit を使う
9495
def create
9596
form = UserRegistrationForm.new(UserRegistrationForm.permit(params))
9697

0 commit comments

Comments
 (0)