moved converter to subpackage

Author: stritti

src/main/java/com/sybit/airtable/Airtable.java

@@ -8,6 +8,8 @@
 
 
 import com.mashape.unirest.http.Unirest;
+import com.sybit.airtable.converter.ListConverter;
+import com.sybit.airtable.converter.MapConverter;
 import com.sybit.airtable.exception.AirtableException;
 import com.sybit.airtable.vo.Attachment;
 import com.sybit.airtable.vo.Thumbnail;

src/main/java/com/sybit/airtable/Base.java

@@ -53,7 +53,7 @@ public Base(String base, Airtable airtable) {
      * Set Airtable object as parent.
      * @param parent the base Airtable object.
      */
-    protected void setParent(Airtable parent) {
+    void setParent(Airtable parent) {
         this.parent = parent;
     }
 

src/main/java/com/sybit/airtable/GsonObjectMapper.java

@@ -15,7 +15,7 @@
  *
  * @author fzr
  */
-class GsonObjectMapper implements ObjectMapper{
+class GsonObjectMapper implements ObjectMapper {
     private static final Logger LOG = Logger.getLogger( GsonObjectMapper.class.getName() );
     private final Gson gson;
 
@@ -25,11 +25,12 @@ public GsonObjectMapper() {
     }
 
     public <T> T readValue(String value, Class<T> valueType) {
-        LOG.log(Level.INFO, "readValue: \n" + value);
+        LOG.log(Level.FINE, "readValue: \n" + value);
         return gson.fromJson(value, valueType);
     }
 
     public String writeValue(Object value) {
+        LOG.log(Level.FINE, "writeValue: \n" + value);
         return gson.toJson(value);
     }
 

src/main/java/com/sybit/airtable/Query.java

@@ -29,8 +29,10 @@ public interface Query {
     List<Sort> getSort();
 
     /**
+     * Define a filter formula.
      *
-     * @return
+     * @see https://support.airtable.com/hc/en-us/articles/203255215-Formula-Field-Reference
+     * @return get the filter formula.
      */
     String filterByFormula();
 }

src/main/java/com/sybit/airtable/Table.java

@@ -110,7 +110,7 @@ public String filterByFormula() {
      * @throws HttpResponseException
      */
     @SuppressWarnings("WeakerAccess")
-    public List<T> select(Query query) throws AirtableException, HttpResponseException {
+    public List<T> select(Query query) throws AirtableException {
         HttpResponse<Records> response;
         try {
             GetRequest request = Unirest.get(getTableEndpointUrl())
@@ -272,7 +272,7 @@ private List<T> getList(HttpResponse<Records> response) {
      * @return searched record.
      * @throws AirtableException
      */
-    public T find(String id) throws AirtableException, HttpResponseException {
+    public T find(String id) throws AirtableException {
 
         RecordItem body = null;
 
@@ -423,7 +423,7 @@ private void setProperty(T retval, String key, Object value) throws IllegalAcces
     private String key2property(String key) {
 
         if(key.contains(" ") || key.contains("-") ) {
-            LOG.warn( "Annotate special characters using @SerializedName for property: [" + key + "]");
+            LOG.warn( "Annotate columns having special characters by using @SerializedName for property: [" + key + "]");
         }
         String property = key.trim();
         property = property.substring(0,1).toLowerCase() + property.substring(1, property.length());

…va/com/sybit/airtable/ListConverter.java …it/airtable/converter/ListConverter.javasrc/main/java/com/sybit/airtable/ListConverter.java renamed to src/main/java/com/sybit/airtable/converter/ListConverter.java src/main/java/com/sybit/airtable/ListConverter.java renamed to src/main/java/com/sybit/airtable/converter/ListConverter.java

@@ -3,14 +3,15 @@
  * To change this template file, choose Tools | Templates
  * and open the template in the editor.
  */
-package com.sybit.airtable;
+package com.sybit.airtable.converter;
 
 import com.google.gson.internal.LinkedTreeMap;
+import org.apache.commons.beanutils.BeanUtils;
+import org.apache.commons.beanutils.converters.AbstractConverter;
+
 import java.lang.reflect.InvocationTargetException;
 import java.util.ArrayList;
 import java.util.List;
-import org.apache.commons.beanutils.BeanUtils;
-import org.apache.commons.beanutils.converters.AbstractConverter;
 
 /**
  * 
@@ -99,7 +100,8 @@ protected <T> T convertToType(final Class<T> type, Object value) throws Instanti
      * @return A List
      */
     private List toStringList(final Class type, final String value,List returnList) {
-         
+
+        //FIXME why this if?
         if (type.equals(String.class)) {      
             returnList.add(String.valueOf(value));
             return returnList;

…ava/com/sybit/airtable/MapConverter.java …bit/airtable/converter/MapConverter.javasrc/main/java/com/sybit/airtable/MapConverter.java renamed to src/main/java/com/sybit/airtable/converter/MapConverter.java src/main/java/com/sybit/airtable/MapConverter.java renamed to src/main/java/com/sybit/airtable/converter/MapConverter.java

@@ -3,7 +3,7 @@
  * To change this template file, choose Tools | Templates
  * and open the template in the editor.
  */
-package com.sybit.airtable;
+package com.sybit.airtable.converter;
 
 import com.google.gson.internal.LinkedTreeMap;
 import com.sybit.airtable.vo.Thumbnail;