Skip to content

Refactor expression language#964

Draft
Florian-Merle wants to merge 1 commit into
Sylius:1.13from
Florian-Merle:refactor-expression-language
Draft

Refactor expression language#964
Florian-Merle wants to merge 1 commit into
Sylius:1.13from
Florian-Merle:refactor-expression-language

Conversation

@Florian-Merle
Copy link
Copy Markdown

@Florian-Merle Florian-Merle commented Dec 13, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets
License MIT

Since the original services were experimental, I consider that this PR does not introduce any BC breaks.

As discussed with @loic425, this PR aims to port back the changes made in this PR but specifically for the SyliusResourceBundle.

To-do:

  • Update tests
  • cleanup src/Bundle/Resources/config/services/expression_language.xml

@Florian-Merle Florian-Merle changed the title wip Refactor expression language Dec 13, 2024
@Florian-Merle Florian-Merle force-pushed the refactor-expression-language branch from 8ba8b9f to e23d9d4 Compare December 13, 2024 15:34
@Florian-Merle Florian-Merle force-pushed the refactor-expression-language branch from e23d9d4 to f8896b1 Compare December 13, 2024 15:35
@loic425 loic425 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants