Fix multimodal#319
Draft
fm1320 wants to merge 6 commits into
Draft
Conversation
fm1320
force-pushed
the
fix-multimodal
branch
from
a71bf37 to
922681a
Compare
liyin2015
reviewed
Jan 27, 2025
| input: Optional[Any] = None, | ||
| model_kwargs: Dict = {}, | ||
| model_type: ModelType = ModelType.UNDEFINED, | ||
| model_type: ModelType = ModelType.UNDEFINED, # Now required in practice |
liyin2015
reviewed
Jan 27, 2025
| response = self.sync_client.images.edit(**api_kwargs) | ||
| else: | ||
| # Image variation | ||
| elif operation == "variation": |
liyin2015
reviewed
Jan 27, 2025
| response = await self.async_client.images.generate(**api_kwargs) | ||
| elif operation == "edit": | ||
| response = await self.async_client.images.edit(**api_kwargs) | ||
| elif operation == "variation": |
liyin2015
reviewed
Jan 27, 2025
| # args for the cache | ||
| cache_path: Optional[str] = None, | ||
| use_cache: bool = False, | ||
| model_type: ModelType = ModelType.LLM, # Add model_type parameter with default |
Member
There was a problem hiding this comment.
dont update it here, let it be controled in the model client
liyin2015
reviewed
Jan 27, 2025
| CallbackManager.__init__(self) | ||
|
|
||
| self.name = name or self.__class__.__name__ | ||
| self.model_type = model_type # Use the passed model_type instead of getting from client |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting