[WIP] Hierarchical printing of graph-like expressions#59
Open
MilesCranmer wants to merge 4 commits intomasterfrom
Open
[WIP] Hierarchical printing of graph-like expressions#59MilesCranmer wants to merge 4 commits intomasterfrom
MilesCranmer wants to merge 4 commits intomasterfrom
Conversation
Contributor
Pull Request Test Coverage Report for Build 7344448443
💛 - Coveralls |
Contributor
Benchmark Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Say we create an expression:
Note that the normal behavior is to encapsulate with
{}when a node is shared.However, we can print this with less redundancy with
pretty_string_graph:which finds the shared nodes, assigns variable names based on their depth, and then prints the program in this hierarchical fashion.
This is only 2x slower than the regular
string_treemethod, so I'm considering have this as the default forGraphNodetypes. For consistency I might need to prepend the=to regular print statements though...Curious to hear your thoughts @AlCap23 @Vaibhavdixit02 @ChrisRackauckas! I played around with a few different ideas for how to visualize this in the REPL and this one seemed like a good option. But interested in more.