fix(codegen): hoist inline local declarations#231
Closed
kabbersokhi-boop wants to merge 1 commit into
Closed
Conversation
Emit local variable declarations before statements when inline assignment expressions introduce a new local, allowing cases like methodCall(z = 1) to generate valid OpenCL. ISSUES CLOSED: Syncleus#97
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actuallyDoIt(z = 1)to generate valid OpenCL instead of throwingCodeGenException.Tests
mvn -q -Dmaven.repo.local=/tmp/aparapi-tools/m2 -Dtest=AssignAndPassAsParameterSimpleTest testmvn -q -Dmaven.repo.local=/tmp/aparapi-tools/m2 -Dtest=AssignAndPassAsParameterSimpleTest,FirstAssignInExpressionTest,AssignAndPassAsParameterTest,ConstantAssignInExpressionTest,MultipleAssignTest,MultipleAssignExprTest testA broader
com.aparapi.codegen.test.*Testrun produced passing reports for executed codegen tests, but the local container eventually failed to start additional 2 GB Surefire forks. No assertion failures were observed.ISSUES CLOSED: #97