fix: address CodeRabbit review issues for PR #584

- ideation-engine.js: replace getAll() (non-existent) with listGotchas()
  and improve empty catch to log the error with context so filtering
  failures are no longer silently ignored

- gotchas-memory.js: replace gap-based reset with true sliding window
  using a timestamps array; prune entries older than errorWindowMs on
  each trackError() call and recompute count/firstSeen from the pruned
  window so errorWindowMs genuinely bounds counted occurrences

- condition-evaluator.js: register six workflow guidance conditions
  (user_wants_ai_generation, stories_remaining, epic_complete,
  architecture_suggests_prd_changes, po_checklist_issues,
  user_has_generated_ui) that are human-driven and cannot be inferred
  from TechStackProfile; defaulting to true preserves backwards
  compatibility with greenfield-ui.yaml after the fail-safe false
  introduced in #472

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: oalanicolas

.aiox-core/core/ideation/ideation-engine.js

@@ -76,10 +76,10 @@ class IdeationEngine {
     let filtered = suggestions;
     if (this.gotchasMemory) {
       try {
-        const knownIssues = await this.gotchasMemory.getAll();
+        const knownIssues = this.gotchasMemory.listGotchas();
         filtered = suggestions.filter((s) => !this.isKnownGotcha(s, knownIssues));
-      } catch {
-        // Ignore
+      } catch (error) {
+        console.warn('[IdeationEngine] Failed to load known gotchas for filtering:', error.message);
       }
     }
 

.aiox-core/core/memory/gotchas-memory.js

@@ -253,6 +253,7 @@ class GotchasMemory extends EventEmitter {
         count: 0,
         firstSeen: now,
         lastSeen: now,
+        timestamps: [],
         samples: [],
         errorPattern: errorData.message,
         category: this._detectCategory(errorData.message + ' ' + (errorData.stack || '')),
@@ -266,9 +267,25 @@ class GotchasMemory extends EventEmitter {
       tracking.samples = [];
     }
 
-    // Update tracking
-    tracking.count++;
+    // Ensure timestamps array exists for entries loaded from disk before this fix
+    if (!Array.isArray(tracking.timestamps)) {
+      tracking.timestamps = [];
+    }
+
+    // Add current timestamp and prune occurrences outside the sliding error window.
+    // This ensures errorWindowMs truly bounds the counted occurrences rather than
+    // relying on inactivity gaps — the previous gap-based reset allowed stale errors
+    // (e.g., at 0h, 20h, 40h) to keep accumulating as long as each repeat landed
+    // just inside the gap boundary.
+    const windowStart = now - this.options.errorWindowMs;
+    tracking.timestamps.push(now);
+    tracking.timestamps = tracking.timestamps.filter((ts) => ts >= windowStart);
+
+    // Recompute derived fields from the pruned sliding window
+    tracking.count = tracking.timestamps.length;
+    tracking.firstSeen = tracking.timestamps.length > 0 ? tracking.timestamps[0] : now;
     tracking.lastSeen = now;
+
     if (tracking.samples.length < 5) {
       tracking.samples.push({
         timestamp: new Date(now).toISOString(),

.aiox-core/core/orchestration/condition-evaluator.js

@@ -97,6 +97,17 @@ class ConditionEvaluator {
       // Composite conditions
       has_any_data_to_analyze: () =>
         this.profile.hasDatabase || this.profile.hasFrontend || this.profile.hasBackend,
+
+      // Workflow guidance conditions — human-driven, cannot be inferred from tech
+      // stack profile. Default to true so these optional/iterative steps are not
+      // silently skipped by the fail-safe false introduced in #472.
+      // Each condition describes intent that the executing agent confirms at runtime.
+      user_wants_ai_generation: () => true, // Optional AI UI generation step
+      stories_remaining: () => true, // Repeat story cycle until agent signals done
+      epic_complete: () => true, // Optional epic retrospective step
+      architecture_suggests_prd_changes: () => true, // Optional PRD update after arch review
+      po_checklist_issues: () => true, // Optional fix delegation when PO finds issues
+      user_has_generated_ui: () => true, // Optional project-setup guidance for generated UI
     };
 
     // Check for built-in evaluator

.aiox-core/install-manifest.yaml

@@ -8,7 +8,7 @@
 # - File types for categorization
 #
 version: 5.0.3
-generated_at: "2026-03-11T02:07:59.305Z"
+generated_at: "2026-03-11T12:49:21.536Z"
 generator: scripts/generate-install-manifest.js
 file_count: 1089
 files:
@@ -689,9 +689,9 @@ files:
     type: core
     size: 7755
   - path: core/ideation/ideation-engine.js
-    hash: sha256:0022cd3c1e9f834be277718ef7edb3378950b568a1a85e24df5ed8a55873098b
+    hash: sha256:2ba5de0721a5496e0484a6c68c4a5657998ba509d0e0bfd8957e9c26286dd9cd
     type: core
-    size: 22871
+    size: 22961
   - path: core/ids/circuit-breaker.js
     hash: sha256:8ded35421a12a87c3de36f17ea9987c2c17d27aff1d3bd875813113de224b7f7
     type: core
@@ -789,9 +789,9 @@ files:
     type: core
     size: 8850
   - path: core/memory/gotchas-memory.js
-    hash: sha256:f6a151445aab302116218ff044b1a379adcd9963ddd77e58cd8bc9eb13cd8597
+    hash: sha256:5f10e5111598c23c2ec27cf945c656fd957494895981aa321a9cfe5360c1a8e8
     type: core
-    size: 33294
+    size: 34193
   - path: core/migration/migration-config.yaml
     hash: sha256:c251213b99ce86c9b15311d51a0b464b7fc25179455c4c6c107cae76cf49d1ab
     type: core
@@ -829,9 +829,9 @@ files:
     type: core
     size: 19293
   - path: core/orchestration/condition-evaluator.js
-    hash: sha256:3beeadc14168659bfa6e86a49fa454e7c54ad55d559a09aa8deee423d068b9a4
+    hash: sha256:a896e92c5b49ea187170d17c396ff4d239e7c355a6bc64b7a45a742959086531
     type: core
-    size: 10846
+    size: 11675
   - path: core/orchestration/context-manager.js
     hash: sha256:7bf273723a2c08cb84e670b9d4c55aacec51819b1fbd5f3b0c46c4ccfa2ec192
     type: core