Skip to content

fix(circuit-breaker): preserve recovery timeout when recordFailure called in OPEN state #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikolasdehor wants to merge 1 commit into from
Closed

fix(circuit-breaker): preserve recovery timeout when recordFailure called in OPEN state #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .aiox-core/core/ids/circuit-breaker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,23 @@ class CircuitBreaker {
* Record a failed operation.
*/
recordFailure() {
this._failureCount++;
this._lastFailureTime = Date.now();

if (this._state === STATE_HALF_OPEN) {
// Any failure in half-open re-opens the circuit
this._halfOpenProbeInFlight = false;
this._state = STATE_OPEN;
this._totalTrips++;
this._failureCount++;
this._successCount = 0;
this._lastFailureTime = Date.now();
} else if (this._state === STATE_CLOSED) {
this._failureCount++;
this._lastFailureTime = Date.now();
if (this._failureCount >= this._failureThreshold) {
this._state = STATE_OPEN;
this._totalTrips++;
}
}
// STATE_OPEN: no-op — do not reset _lastFailureTime so recovery timeout is preserved
}

/**
Expand Down
6 changes: 3 additions & 3 deletions .aiox-core/install-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# - File types for categorization
#
version: 5.0.3
generated_at: "2026-03-11T15:04:09.395Z"
generated_at: "2026-03-13T00:48:04.596Z"
generator: scripts/generate-install-manifest.js
file_count: 1090
files:
Expand Down Expand Up @@ -693,9 +693,9 @@ files:
type: core
size: 22865
- path: core/ids/circuit-breaker.js
hash: sha256:1b35331ba71a6ce17869bab255e087fc540291243f9884fc21ed89f7efc122a4
hash: sha256:407ae5ab689d834fa027a20db48d1696238b7393c3beeb0ec9d1651d5a832b17
type: core
size: 4235
size: 4400
- path: core/ids/framework-governor.js
hash: sha256:ef7a3b7444a51f2f122c114c662b1db544d1c9e7833dc6f77dce30ac3a2005a2
type: core
Expand Down
Loading
Loading