Skip to content

fix: enforce aiox-master delegation-first authority - #662

Merged
rafaelscosta merged 1 commit into
mainfrom
fix/issue-527-master-delegation-20260507
May 7, 2026
Merged

fix: enforce aiox-master delegation-first authority#662
rafaelscosta merged 1 commit into
mainfrom
fix/issue-527-master-delegation-20260507

Conversation

@rafaelscosta

@rafaelscosta rafaelscosta commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces the old universal-executor wording for @aiox-master with a mandatory pre-execution authority check.
  • Makes delegation the default for specialized work in .claude/rules/agent-authority.md while preserving direct execution for framework governance, workflow-engine mode, and explicit --force-execute framework debugging.
  • Removes create-next-story from the aiox-master command/dependency surface and syncs generated IDE/agent artifacts.
  • Adds a governance regression test that blocks the old "No restrictions" / universal execution phrases from published surfaces.

Existing PR Review

Validation

  • npm run validate:agents (pass; existing dependency warnings only)
  • npm run sync:ide:check
  • npm run validate:manifest
  • git diff --check
  • npm run lint -- --quiet
  • npm run typecheck
  • npm run validate:publish
  • npm test -- tests/governance/aiox-master-delegation.test.js tests/ide-sync/transformers.test.js tests/integration/codex-skills-sync.test.js --runInBand
  • npm run test:ci (313 suites passed, 7,821 tests passed, 149 skipped)

Closes #527

Summary by CodeRabbit

  • Tests

    • Added governance compliance test suite validating agent authority checks and delegation rules.
  • Chores

    • Version updated to 5.1.3.
    • Updated agent orchestration configurations and framework governance rules across development and operational guidelines.

@vercel

vercel Bot commented May 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aiox-core Ready Ready Preview, Comment May 7, 2026 11:06am

Request Review

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR implements a governance redesign for aiox-master, transitioning it from a universal executor that can handle any task to a master orchestrator that delegates specialized work by default. The change adds mandatory pre-execution authority checks, constrains direct execution to framework governance/orchestration/debugging, and maps specific task types to specialized agents. Configuration updates span multiple rule locations, with corresponding governance tests validating the new model.

Changes

aiox-master Governance & Delegation Model

Layer / File(s) Summary
Conceptual Framework & Authority Rules
.aiox-core/data/aiox-kb.md, .claude/rules/agent-authority.md
Knowledge base redefines aiox-master as "Master Orchestrator" (from "Universal Expert"). Authority rules add pre-execution ownership verification and execution/delegation/blocked categories.
Agent Persona & Core Principles
.aiox-core/development/agents/aiox-master.md, .claude/skills/AIOX/agents/aiox-master/SKILL.md, .codex/agents/aiox-master.md, .gemini/rules/AIOX/agents/aiox-master.md, .github/agents/aiox-master.agent.md
All agent configuration files redefined from universal executor to master orchestrator with mandatory pre-execution authority check as first principle. Direct execution now limited to framework governance/orchestration or explicit --force-execute.
Agent Delegation & Routing
.aiox-core/development/agents/aiox-master.md, .claude/skills/AIOX/agents/aiox-master/SKILL.md, .codex/agents/aiox-master.md, .gemini/rules/AIOX/agents/aiox-master.md
New routing responsibilities section specifies framework development/debugging boundaries. Explicit delegation mapping routes epics/PRD/specs to @pm, story creation to @sm, backlog to @po, implementation to @dev, and git/PR/release to @devops.
Story Creation Delegation
.aiox-core/development/agents/aiox-master.md, .claude/skills/AIOX/agents/aiox-master/SKILL.md, .codex/agents/aiox-master.md, .gemini/rules/AIOX/agents/aiox-master.md
Removes create-next-story command from all configurations. Adds explicit notes that story creation is exclusive domain of @sm agent. Updates task dependencies to remove story-creation references.
Command Set & Tooling
.antigravity/rules/agents/aiox-master.md
Antigravity rules add documentation-generation commands (*create-doc, *doc-out, *shard-doc, *document-project, *add-tech-doc) and remove *create-next-story.
Manifest & Package Version
.aiox-core/install-manifest.yaml, package.json
Manifest version bumped 5.1.2 → 5.1.3 with updated SHA256 hashes for modified files. Package.json version synchronized.
Governance Test Coverage
tests/governance/aiox-master-delegation.test.js
New Jest suite with 54 lines validates: no forbidden universal-execution phrases in published surfaces, pre-execution check language present in canonical config, delegation-default and constraint language in authority rules.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

  • SynkraAI/aiox-core#641: Overlapping edits to aiox-master agent personas and delegation semantics across multiple configuration files.

Suggested labels

type: docs, area: agents, area: workflows, type: test, area: core

Suggested reviewers

  • Pedrovaleriolopez
  • oalanicolas
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: enforce aiox-master delegation-first authority' accurately describes the main objective of the PR—refactoring @aiox-master to default to delegation rather than direct execution.
Linked Issues check ✅ Passed The PR successfully addresses all four gaps identified in issue #527: introduces pre-execution authority checks, replaces 'No restrictions' with explicit delegation rules, adds governance tests, and syncs agent surface files.
Out of Scope Changes check ✅ Passed All changes directly support the delegation-first authority enforcement objective; version bumps and manifest regeneration are expected housekeeping for documentation-driven changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-527-master-delegation-20260507

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added area: agents Agent system related area: workflows Workflow system related squad mcp type: test Test coverage and quality area: core Core framework (.aios-core/core/) area: installer Installer and setup (packages/installer/) area: synapse SYNAPSE context engine area: cli CLI tools (bin/, packages/aios-pro-cli/) area: pro Pro features (pro/) area: health-check Health check system area: docs Documentation (docs/) area: devops CI/CD, GitHub Actions (.github/) labels May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

Coverage report not available

📈 Full coverage report available in Codecov


Generated by PR Automation (Story 6.1)

@rafaelscosta
rafaelscosta merged commit 80485c6 into main May 7, 2026
40 of 41 checks passed
@rafaelscosta
rafaelscosta deleted the fix/issue-527-master-delegation-20260507 branch May 7, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: agents Agent system related area: cli CLI tools (bin/, packages/aios-pro-cli/) area: core Core framework (.aios-core/core/) area: devops CI/CD, GitHub Actions (.github/) area: docs Documentation (docs/) area: health-check Health check system area: installer Installer and setup (packages/installer/) area: pro Pro features (pro/) area: synapse SYNAPSE context engine area: workflows Workflow system related mcp squad type: test Test coverage and quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@aios-master executes exclusive tasks directly instead of delegating — "No restrictions" label causes enforcement gap

1 participant