fix(execution): preserve ResultAggregator falsy defaults (#611)

[rafaelscosta]

Summary

Clean replacement for stale PR #611.

• Preserves valid falsy values in ResultAggregator defaults (waveIndex: 0, duration: 0, empty string output/agent IDs, maxHistory: 0).
• Keeps filesModified safe by accepting arrays only and falling back to output parsing for invalid non-array values.
• Fixes report/markdown fallbacks so wave zero generates wave-results-0.json and zero metrics render as 0, not alternate values or N/A.
• Bumps @aiox-squads/core to 5.1.9 and regenerates the install manifest/entity registry.

Validation

• node -c .aiox-core/core/execution/result-aggregator.js
• npm test -- tests/core/result-aggregator.test.js --runInBand
• npm test -- tests/core/result-aggregator.test.js tests/core/wave-executor.test.js tests/core/build-state-manager.test.js --runInBand --forceExit
• npm run validate:manifest
• npm run validate:publish
• npm run lint -- --quiet
• npm run typecheck
• git diff --check
• npm run test:ci -> 315 suites passed / 7,846 tests passed / 149 skipped

Notes

The old PR branch had stale CI/manifest failures and CodeRabbit feedback about mechanically preserving non-array task lists. This replacement keeps the fix scoped to ResultAggregator and adds explicit array normalization where needed.

Summary by CodeRabbit

• Bug Fixes

  • Result aggregator now correctly preserves valid falsy values (zero wave indices, zero durations, empty strings) in aggregation and report generation instead of treating them as missing.

• Tests

  • Added comprehensive test coverage for falsy-but-valid configuration and result values.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
aiox-core	Ready	Preview, Comment	May 7, 2026 3:12pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 86df1387-ad8d-48a7-929e-7132df43be61

📥 Commits

Reviewing files that changed from the base of the PR and between 524c12c and 053730b.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (6)

• .aiox-core/core/execution/result-aggregator.js
• .aiox-core/data/entity-registry.yaml
• .aiox-core/install-manifest.yaml
• docs/stories/epic-123/STORY-123.13-result-aggregator-falsy-defaults.md
• package.json
• tests/core/result-aggregator.test.js

---

Walkthrough

This PR updates ResultAggregator to use nullish-coalescing (??) instead of logical OR (||) for preserving intentional falsy values like 0, empty strings, and maxHistory: 0 throughout configuration defaults, task aggregation, and report generation, with corresponding test coverage and version bump to 5.1.9.

Changes

Falsy Value Handling in ResultAggregator

Layer / File(s)	Summary
Story and Requirements docs/stories/epic-123/STORY-123.13-result-aggregator-falsy-defaults.md	Documents acceptance criteria for preserving falsy but valid metrics (waveIndex: 0, duration: 0, empty strings) during aggregation and reporting instead of replacing them with defaults.
Core Logic Refactor .aiox-core/core/execution/result-aggregator.js	Constructor switches from || to ?? for rootPath, reportDir, and maxHistory; aggregation preserves falsy wave/task values; report filename and markdown rendering use ?? for zero metrics; duration rendering checks != null instead of truthiness.
Test Coverage tests/core/result-aggregator.test.js	Constructor test verifies falsy config preservation; aggregate tests cover waveIndex: 0, zero duration/output, non-array filesModified fallback, and maxHistory: 0 history trimming; report and formatMarkdown tests validate zero metrics in filenames and markdown output.
Version and Manifests package.json, .aiox-core/install-manifest.yaml, .aiox-core/data/entity-registry.yaml	Package version bumped to 5.1.9; install manifest and entity registry updated with new SHA256 hashes and timestamps for result-aggregator.js and capability-detection.js.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• Pedrovaleriolopez
• oalanicolas

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/pr-611-result-aggregator-falsy-20260507

Warning

Tools execution failed with the following error:

Failed to run tools: 14 UNAVAILABLE: read ECONNRESET

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📊 Coverage Report

Coverage report not available

📈 Full coverage report available in Codecov

---

Generated by PR Automation (Story 6.1)