fix: publish Claude settings with core package - #672
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rafaelscosta
requested review from
Pedrovaleriolopez and
oalanicolas
as code owners
May 7, 2026 16:19
github-actions
Bot
added
area: agents
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR ensures ChangesClaude Settings Package Inclusion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/validate-package-completeness.js`:
- Around line 67-70: The current validation uses startsWith for every
REQUIRED_FILES_ENTRIES item (including concrete files like
'.claude/settings.json'), allowing false positives such as
'.claude/settings.json.bak'; update the validation logic that iterates
REQUIRED_FILES_ENTRIES so that entries ending with '/' are treated as directory
prefixes (use startsWith) while entries not ending with '/' are matched with
exact equality (use ===) against file paths; locate the check around the
startWith usage (referencing REQUIRED_FILES_ENTRIES and the validation
function/block that performs the startsWith check on line ~217) and implement
the dual-branch matching (prefix for directories, exact for files).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 627bc975-d632-4763-a011-c44769ff8ce8
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
docs/stories/epic-123/STORY-123.17-publish-claude-settings-contract.mdpackage.jsonscripts/validate-package-completeness.js
5 tasks
tuanmedeiros
pushed a commit
to tuanmedeiros/aios-core-synkraay
that referenced
this pull request
Jun 2, 2026
* fix: publish Claude settings with core package * fix: require exact package file entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/settings.jsonin the npm package files contract.claude/settings.jsonin package completeness validationValidation
git diff --checknode scripts/validate-package-completeness.js(32/32)npm pack --dry-run --jsonincludes.claude/settings.jsonnpm run validate:publishnpm run validate:semantic-lintnpm run validate:manifestnpm run lint -- --quietnpm run typechecknpm run test:ci(315 suites / 7,847 tests)Context
Follow-up to #671:
5.1.11published the version bump and CLI, but the package tarball did not include.claude/settings.json, so the shell-neutral hook settings were only available in the repo checkout. This closes the package contract.Summary by CodeRabbit
New Features
Chores