fix: address governance PR review feedback - #681
Closed
rafaelscosta wants to merge 6 commits into
Closed
Conversation
…md ao atingir 5+
Estabelece regra operacional de governança de pipelines longos:
- Threshold: 5+ handoffs YAML para mesmo pipeline → MUST consolidar
- RUN-LOG.md vai em docs/stories/epics/{epic}/RUN-LOG.md (preferred)
- Handoff mais recente sempre fica individual (next session reads first)
- Originais arquivados em .aiox/handoffs/_archive/ (default)
- Preserva: contexto estratégico, ADRs, blockers resolvidos, schema changes
- Descarta: investigation steps, alternativas rejeitadas, tool sequences
Trigger desta sessão: pipeline meta-messaging Wave 1 → Wave 2 transition.
Mirror em business-ai-first/.claude/rules/handoff-consolidation.md (PR #59).
Atualiza CLAUDE.md (tabela de rules) com referência à nova regra.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
) Establishes formal AIOX framework R&D pipeline triggered by Wave 1.A correction in business-ai-first that exposed two systemic gaps: 1. No formal route for project-level audit findings to evolve framework 2. @aiox-master orchestrator has no triage.routing_matrix to consult specialized squads first when topic matches their domain ## What this PR adds ### audits/ - README.md — folder doctrine - c-dev-organization-2026-05-07.md — narrative audit of C:/dev workspace - promoted/AF-20260507-vocabulary-contract-failure.yaml — finding - promoted/AF-20260507-aiox-master-routing-gap.yaml — finding ### governance/ - README.md — folder index - evolution-pipeline.md — formal R&D pipeline spec (audit -> proposal -> Eliel approval -> PR) - squad-activation-strategy.md — conditional consult-squad-first routing - templates/audit-finding-tmpl.yaml — AuditFinding template - templates/framework-proposal-tmpl.yaml — FrameworkProposal template - proposals/README.md — proposal lifecycle doc - proposals/PROP-20260507-vocabulary-contract.yaml — pending Eliel approval - proposals/PROP-20260507-squad-routing-strategy.yaml — pending Eliel approval - patterns/README.md — pattern catalog (catalog scaffold) ## Why this matters Without the pipeline, every project re-discovers the same lessons, voice-clone squads stay dormant, claude-code-mastery never gets invoked from outside, and tokens burn on context redundancy. Eliel's diagnostic: "todos os plans criados cogitaram em nenhum momento a perfeita integração desses squads". The pipeline is the discipline; the routing matrix is the mechanism. ## What this PR does NOT do (deferred to follow-up PRs after approval) - Patch aiox-master.md to add triage block (separate PR per proposal approval) - Add aiox-core/hooks/migration-dictionary-guard.cjs (separate PR) - Add aiox-core/hooks/squad-suggestion-advisor.cjs (separate PR) - Constitution amendment Article VII (separate PR) This PR is governance-only. Implementation follows once Eliel signs the two pending proposals. ## Authority - Authors: @aiox-master (Orion) on Eliel's request - Approver of governance content: Eliel (sole orchestrator approver) - Reference: voice-clone formal opinions captured in business-ai-first ADR-DBOPS-V1-vocabulary-contract-failure.md Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Eliel approved both proposals on 2026-05-07T19:15:00Z: - PROP-20260507-vocabulary-contract: APPROVED Closes Akita's Article VII gap. Generalizes migration-dictionary-guard hook from business-ai-first project-local copy to framework. Prevents Wave 1.A failure mode (V1 reverted) in any future AIOX project. - PROP-20260507-squad-routing-strategy: APPROVED Adds triage.routing_matrix to @aiox-master. Advisory hook suggests squads (voice-clones, claude-code-mastery, audience-engine, db-inventory) by keyword match. Closes Eliel-declared squad integration gap. Implementation order: vocabulary-contract first, then squad-routing references Article VII once formalized. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rafaelscosta
requested review from
Pedrovaleriolopez and
oalanicolas
as code owners
May 7, 2026 23:24
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
area: agents
WalkthroughThis PR establishes the governance infrastructure for aiox-core framework evolution: a formal audit-to-proposal pipeline for converting consumer project findings into framework improvements, along with configuration updates, workspace management rules, and a squad activation routing strategy for intelligent agent consultation. ChangesFramework Governance System
Audit & Finding Infrastructure
Configuration, Rules & Workspace Setup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The PR introduces substantial governance structure and audit documentation (406 lines for evolution pipeline alone, 306 for squad activation strategy) with mixed complexity: governance templates and rules are straightforward documentation, but the squad activation routing matrix, proposal mechanics, and audit finding structures require careful verification that processes are coherent and operationally sound. Configuration and story changes are straightforward additions. Heterogeneous across governance/audit/config domains demands separate reasoning for each, but individual sections follow clear patterns. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
Contributor
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/rules/handoff-consolidation.md:
- Line 19: The table row currently in Portuguese ("5+ recurrente | Reconsolidar
a cada 5 novos handoffs") must be converted to the same language as the rest of
the document; replace that exact row with an English equivalent such as "5+
recurring | Reconsolidate after every 5 new handoffs" so the threshold language
is consistent; update the string matching "5+ recurrente | Reconsolidar a cada 5
novos handoffs" accordingly in .claude/rules/handoff-consolidation.md.
In @.env.example:
- Line 47: Add a prominent security warning for SUPABASE_SERVICE_ROLE_KEY near
the variable declaration (the SUPABASE_SERVICE_ROLE_KEY entry) explaining that
it bypasses Postgres Row Level Security (RLS), grants unrestricted DB access,
and must never be committed to VCS or used in client-side code; update the
existing generic header (around the top comment) to call out this elevated risk
and recommend using SUPABASE_ANON_KEY for frontend and secrets management (e.g.,
environment/secret manager) for service role usage.
In `@audits/promoted/AF-20260507-vocabulary-contract-failure.yaml`:
- Line 56: The path in the commit message/diff contains a stray leading dot:
update the string ".aiox-core/constitution.md" to "aiox-core/constitution.md" so
it matches the other entry and standard non-hidden directory naming; locate the
occurrence in the diff line that reads 'Add Article VII (Vocabulary Contract) to
.aiox-core/constitution.md' and remove the leading period from the directory
segment.
- Line 50: The path entry uses a shell-style brace
"{fabio-akita,lucas-montano}.md" which is treated as a single YAML string;
replace it with two explicit entries so each persona has its own path (e.g.,
create separate list items with path:
"business-ai-first/squads/voice-clones/agents/fabio-akita.md" and path:
"business-ai-first/squads/voice-clones/agents/lucas-montano.md"), or if the
schema requires a single scalar per object, add a second top-level object
(duplicate the existing kind: voice-clone-personas block) with the other path;
update the "path" field(s) and/or duplicate the entry accordingly so the YAML
contains two real paths instead of a brace-expanded literal.
In `@governance/evolution-pipeline.md`:
- Around line 281-282: Replace the invalid "kind: voice-clone-opinions" entry
with one of the allowed taxonomy kinds from the templates so the example is
schema-valid; specifically locate the "kind: voice-clone-opinions" line (and its
associated path
"business-ai-first/squads/voice-clones/agents/{fabio-akita,lucas-montano}.md")
and change the kind value to a permitted kind name listed in the templates
(e.g., the appropriate opinions or agent-related kind) so the example conforms
to the documented schema.
- Around line 49-50: The docs reference the wrong approval field name: update
the "If APPROVED" bullet so it states the proposal is signed using the schema
field approval.eliel_decision (and include timestamp and rationale) instead of
eliel_approval; ensure any adjacent text that describes metadata/PR creation
reflects this exact field path so runtime code reading proposal metadata will
match the defined schema.
In `@governance/proposals/PROP-20260507-squad-routing-strategy.yaml`:
- Around line 73-75: The implementation block currently has an empty pr_url and
merged_at which breaks the decision→implementation trace; update the
implementation object by setting pr_url to the actual implementation PR URL (or
a clear token like "PENDING: <reason>" if the PR is not yet opened) and adjust
merged_at to either the merge timestamp once merged or leave it as an explicit
pending marker (e.g., "PENDING") so consumers of the PROP-... document can
unambiguously know the implementation status; modify the fields in the
implementation section (pr_url and merged_at) accordingly.
In `@governance/proposals/PROP-20260507-vocabulary-contract.yaml`:
- Around line 74-76: The proposal's implementation block is missing the
implementing PR link; update the implementation.pr_url field in
PROP-20260507-vocabulary-contract.yaml (and set implementation.merged_at when
the PR is merged) by adding the implementing pull request URL or the literal
"pending PR creation" to maintain an auditable approval→implementation trace;
ensure you edit the implementation.pr_url value (and later populate
implementation.merged_at with an ISO timestamp when merged).
In `@governance/squad-activation-strategy.md`:
- Around line 248-253: The hook spec is inconsistent: it labels the hook as
"PreToolUse" but states it "runs only on UserPromptSubmit"; decide which trigger
model is correct (either PreToolUse or UserPromptSubmit), update the Trigger
line to match the chosen model, and ensure any descriptive text (e.g., the
comment header "// PreToolUse hook" and the line "runs only on
UserPromptSubmit") and downstream references use the same term; verify the
Trigger: description ("any user message that contains squad-routing keywords")
and the Execution context/Mode remain correct for the selected trigger so
implementations wiring the PreToolUse or UserPromptSubmit hook will be
unambiguous.
In `@governance/templates/framework-proposal-tmpl.yaml`:
- Around line 20-23: The template comments for the fields layer, artifact_type,
and operation currently imply single-value enums; update them to explicitly
permit composite/multi-value syntax (e.g., "L1+L2", "create + modify") or pick a
single canonical approach — if allowing composites, change the inline comments
on the layer, artifact_type, and operation lines to state "single value or
'+'-separated list (e.g., 'L1+L2')" and give an example for operation like
"create + modify"; if standardizing to single values, update the template
comments to state "single value only" and remove any examples that show
composites. Ensure the changes are applied to the layer, artifact_type, and
operation comment lines so semantic validation rules can be implemented
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7f355e0d-f070-4ce2-868f-7f58d9069966
📒 Files selected for processing (18)
.claude/CLAUDE.md.claude/commands/AIOX/stories/story-7.1.1.md.claude/rules/handoff-consolidation.md.claude/settings.json.env.exampleaudits/README.mdaudits/c-dev-organization-2026-05-07.mdaudits/promoted/AF-20260507-aiox-master-routing-gap.yamlaudits/promoted/AF-20260507-vocabulary-contract-failure.yamlgovernance/README.mdgovernance/evolution-pipeline.mdgovernance/patterns/README.mdgovernance/proposals/PROP-20260507-squad-routing-strategy.yamlgovernance/proposals/PROP-20260507-vocabulary-contract.yamlgovernance/proposals/README.mdgovernance/squad-activation-strategy.mdgovernance/templates/audit-finding-tmpl.yamlgovernance/templates/framework-proposal-tmpl.yaml
| |---|---| | ||
| | 1-4 | Keep as individual YAMLs | | ||
| | **5+** | **MUST consolidate** older handoffs into `RUN-LOG.md` | | ||
| | 5+ recurrente | Reconsolidar a cada 5 novos handoffs | |
There was a problem hiding this comment.
Standardize the threshold row language.
Line 19 switches to Portuguese (5+ recurrente | Reconsolidar a cada 5 novos handoffs) while the rest of the rule is in English. Keep this row in one language to avoid interpretation drift in governance enforcement.
🧰 Tools
🪛 LanguageTool
[grammar] ~19-~19: Ensure spelling is correct
Context: ...older handoffs into RUN-LOG.md | | 5+ recurrente | Reconsolidar a cada 5 novos handoffs ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~19-~19: Ensure spelling is correct
Context: ...s into RUN-LOG.md | | 5+ recurrente | Reconsolidar a cada 5 novos handoffs | ## Consolidation Pr...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/rules/handoff-consolidation.md at line 19, The table row currently
in Portuguese ("5+ recurrente | Reconsolidar a cada 5 novos handoffs") must be
converted to the same language as the rest of the document; replace that exact
row with an English equivalent such as "5+ recurring | Reconsolidate after every
5 new handoffs" so the threshold language is consistent; update the string
matching "5+ recurrente | Reconsolidar a cada 5 novos handoffs" accordingly in
.claude/rules/handoff-consolidation.md.
| # Supabase (database, auth, storage) | ||
| # Get from your Supabase project settings | ||
| SUPABASE_ANON_KEY= | ||
| SUPABASE_SERVICE_ROLE_KEY= |
There was a problem hiding this comment.
Add a security warning for SUPABASE_SERVICE_ROLE_KEY — it bypasses RLS entirely.
Unlike SUPABASE_ANON_KEY, the service role key skips every Postgres Row Level Security policy and has unrestricted database access. The generic header on line 5 ("DO NOT commit .env with real credentials") does not communicate this elevated risk, making it easy for a developer to set and forget without understanding the blast radius of a leak.
🛡️ Proposed addition
-SUPABASE_SERVICE_ROLE_KEY=
+# ⚠️ WARNING: This key bypasses ALL Row Level Security (RLS) policies.
+# Treat it like a root password — never expose it to browser or client code.
+SUPABASE_SERVICE_ROLE_KEY=🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.env.example at line 47, Add a prominent security warning for
SUPABASE_SERVICE_ROLE_KEY near the variable declaration (the
SUPABASE_SERVICE_ROLE_KEY entry) explaining that it bypasses Postgres Row Level
Security (RLS), grants unrestricted DB access, and must never be committed to
VCS or used in client-side code; update the existing generic header (around the
top comment) to call out this elevated risk and recommend using
SUPABASE_ANON_KEY for frontend and secrets management (e.g., environment/secret
manager) for service role usage.
| - kind: hook | ||
| path: "business-ai-first/.claude/hooks/migration-dictionary-guard.cjs" | ||
| - kind: voice-clone-personas | ||
| path: "business-ai-first/squads/voice-clones/agents/{fabio-akita,lucas-montano}.md" |
There was a problem hiding this comment.
Shell brace expansion {fabio-akita,lucas-montano}.md is a literal YAML string, not two paths.
YAML does not expand shell braces, so this resolves to the single string "...agents/{fabio-akita,lucas-montano}.md" — a path that does not exist. Two separate list entries are needed.
🔧 Proposed fix
- path: "business-ai-first/squads/voice-clones/agents/{fabio-akita,lucas-montano}.md"
+ path:
+ - "business-ai-first/squads/voice-clones/agents/fabio-akita.md"
+ - "business-ai-first/squads/voice-clones/agents/lucas-montano.md"Note: if the schema enforces
pathas a scalar string, use two separate- kind: voice-clone-personasentries instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@audits/promoted/AF-20260507-vocabulary-contract-failure.yaml` at line 50, The
path entry uses a shell-style brace "{fabio-akita,lucas-montano}.md" which is
treated as a single YAML string; replace it with two explicit entries so each
persona has its own path (e.g., create separate list items with path:
"business-ai-first/squads/voice-clones/agents/fabio-akita.md" and path:
"business-ai-first/squads/voice-clones/agents/lucas-montano.md"), or if the
schema requires a single scalar per object, add a second top-level object
(duplicate the existing kind: voice-clone-personas block) with the other path;
update the "path" field(s) and/or duplicate the entry accordingly so the YAML
contains two real paths instead of a brace-expanded literal.
|
|
||
| proposed_disposition: | ||
| - "Promote business-ai-first/.claude/hooks/migration-dictionary-guard.cjs → aiox-core/hooks/ as framework hook" | ||
| - "Add Article VII (Vocabulary Contract) to .aiox-core/constitution.md" |
There was a problem hiding this comment.
Likely typo: .aiox-core/ should be aiox-core/ (no leading dot).
Line 56 uses .aiox-core/constitution.md while line 57 correctly uses aiox-core/governance/.... A hidden directory name here would be non-standard and inconsistent.
✏️ Proposed fix
- - "Add Article VII (Vocabulary Contract) to .aiox-core/constitution.md"
+ - "Add Article VII (Vocabulary Contract) to aiox-core/constitution.md"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - "Add Article VII (Vocabulary Contract) to .aiox-core/constitution.md" | |
| - "Add Article VII (Vocabulary Contract) to aiox-core/constitution.md" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@audits/promoted/AF-20260507-vocabulary-contract-failure.yaml` at line 56, The
path in the commit message/diff contains a stray leading dot: update the string
".aiox-core/constitution.md" to "aiox-core/constitution.md" so it matches the
other entry and standard non-hidden directory naming; locate the occurrence in
the diff line that reads 'Add Article VII (Vocabulary Contract) to
.aiox-core/constitution.md' and remove the leading period from the directory
segment.
Comment on lines
+49
to
+50
| - If APPROVED: signs the proposal with `eliel_approval` field + timestamp | ||
| - Approval triggers PR creation against `aiox-core` |
There was a problem hiding this comment.
Fix approval field name to match the actual schema.
Line 49 says proposals are signed with eliel_approval, but the defined schema uses approval.eliel_decision (+ timestamp/rationale). This mismatch can produce invalid proposal metadata during execution of the process.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/evolution-pipeline.md` around lines 49 - 50, The docs reference
the wrong approval field name: update the "If APPROVED" bullet so it states the
proposal is signed using the schema field approval.eliel_decision (and include
timestamp and rationale) instead of eliel_approval; ensure any adjacent text
that describes metadata/PR creation reflects this exact field path so runtime
code reading proposal metadata will match the defined schema.
Comment on lines
+281
to
+282
| - kind: voice-clone-opinions | ||
| path: "business-ai-first/squads/voice-clones/agents/{fabio-akita,lucas-montano}.md" |
There was a problem hiding this comment.
Use a reference kind that exists in the allowed taxonomy.
The worked example uses kind: voice-clone-opinions, which does not match the allowed kinds documented in the templates. Please replace it with an allowed value to keep examples schema-valid.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/evolution-pipeline.md` around lines 281 - 282, Replace the invalid
"kind: voice-clone-opinions" entry with one of the allowed taxonomy kinds from
the templates so the example is schema-valid; specifically locate the "kind:
voice-clone-opinions" line (and its associated path
"business-ai-first/squads/voice-clones/agents/{fabio-akita,lucas-montano}.md")
and change the kind value to a permitted kind name listed in the templates
(e.g., the appropriate opinions or agent-related kind) so the example conforms
to the documented schema.
Comment on lines
+73
to
+75
| implementation: | ||
| pr_url: "" | ||
| merged_at: "" |
There was a problem hiding this comment.
Add the implementation PR URL after approval.
With approval already granted, leaving Line 74 blank breaks the expected governance chain from decision → implementation artifact. Please fill pr_url (or note explicit pending state).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/proposals/PROP-20260507-squad-routing-strategy.yaml` around lines
73 - 75, The implementation block currently has an empty pr_url and merged_at
which breaks the decision→implementation trace; update the implementation object
by setting pr_url to the actual implementation PR URL (or a clear token like
"PENDING: <reason>" if the PR is not yet opened) and adjust merged_at to either
the merge timestamp once merged or leave it as an explicit pending marker (e.g.,
"PENDING") so consumers of the PROP-... document can unambiguously know the
implementation status; modify the fields in the implementation section (pr_url
and merged_at) accordingly.
Comment on lines
+74
to
+76
| implementation: | ||
| pr_url: "" | ||
| merged_at: "" |
There was a problem hiding this comment.
Populate implementation PR link for approved proposal traceability.
Since this proposal is already APPROVED, Line 75 should include the implementing PR URL (or explicitly mark “pending PR creation”) to keep the approval-to-implementation chain auditable.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/proposals/PROP-20260507-vocabulary-contract.yaml` around lines 74
- 76, The proposal's implementation block is missing the implementing PR link;
update the implementation.pr_url field in PROP-20260507-vocabulary-contract.yaml
(and set implementation.merged_at when the PR is merged) by adding the
implementing pull request URL or the literal "pending PR creation" to maintain
an auditable approval→implementation trace; ensure you edit the
implementation.pr_url value (and later populate implementation.merged_at with an
ISO timestamp when merged).
Comment on lines
+248
to
+253
| // PreToolUse hook | ||
| // Trigger: any user message that contains squad-routing keywords | ||
| // Action: emit stderr advisory listing relevant squads | ||
| // Mode: advisory (does not block) | ||
| // Cost: ~1ms per check; runs only on UserPromptSubmit (not every tool call) | ||
| ``` |
There was a problem hiding this comment.
Resolve the hook trigger contradiction.
Line 248 says this is a PreToolUse hook, but Line 252 says it runs only on UserPromptSubmit. Please pick one trigger model and keep the spec consistent, otherwise implementation can wire the hook incorrectly.
Proposed doc fix
-// PreToolUse hook
+// UserPromptSubmit hook
// Trigger: any user message that contains squad-routing keywords
// Action: emit stderr advisory listing relevant squads
// Mode: advisory (does not block)
-// Cost: ~1ms per check; runs only on UserPromptSubmit (not every tool call)
+// Cost: ~1ms per check; runs only on UserPromptSubmit🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/squad-activation-strategy.md` around lines 248 - 253, The hook
spec is inconsistent: it labels the hook as "PreToolUse" but states it "runs
only on UserPromptSubmit"; decide which trigger model is correct (either
PreToolUse or UserPromptSubmit), update the Trigger line to match the chosen
model, and ensure any descriptive text (e.g., the comment header "// PreToolUse
hook" and the line "runs only on UserPromptSubmit") and downstream references
use the same term; verify the Trigger: description ("any user message that
contains squad-routing keywords") and the Execution context/Mode remain correct
for the selected trigger so implementations wiring the PreToolUse or
UserPromptSubmit hook will be unambiguous.
Comment on lines
+20
to
+23
| layer: "" # L1 (Core) | L2 (Templates) | L3 (Project Config) | ||
| artifact_type: "" # agent | rule | hook | task | template | governance | workflow | ||
| artifact_path: "" # intended path in aiox-core | ||
| operation: "" # create | modify | deprecate |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win
Align enum guidance with actual multi-value proposal usage.
Lines 20–23 currently imply single-value enums, but approved proposal files in this PR use composite values (e.g., L1+L2, create + modify). Please either (a) formally allow list/composite syntax in the template comments or (b) standardize proposals to strict single values, so semantic validation is unambiguous.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@governance/templates/framework-proposal-tmpl.yaml` around lines 20 - 23, The
template comments for the fields layer, artifact_type, and operation currently
imply single-value enums; update them to explicitly permit composite/multi-value
syntax (e.g., "L1+L2", "create + modify") or pick a single canonical approach —
if allowing composites, change the inline comments on the layer, artifact_type,
and operation lines to state "single value or '+'-separated list (e.g.,
'L1+L2')" and give an example for operation like "create + modify"; if
standardizing to single values, update the template comments to state "single
value only" and remove any examples that show composites. Ensure the changes are
applied to the layer, artifact_type, and operation comment lines so semantic
validation rules can be implemented accordingly.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #678.
Summary
Validation
Notes
Summary by CodeRabbit
New Features
Chores