chore(governance): approve proposals and apply review fixes by rafaelscosta · Pull Request #682 · SynkraAI/aiox-core

rafaelscosta · 2026-05-07T23:42:21Z

Summary

Supersedes #678 because the original cross-repo branch has maintainer edits disabled and rejected direct push.

Carries forward the approved governance proposal metadata for:

PROP-20260507-vocabulary-contract
PROP-20260507-squad-routing-strategy

Also applies the CodeRabbit review fixes from #678:

restores the current ownership-annotated .claude/CLAUDE.md contract and labels fenced code blocks
canonicalizes proposal decision values to APPROVED / REJECTED
updates the patterns catalog to APPROVED
fixes governance cross-reference/status drift and markdown fence labels
aligns .env.example key ordering and the story status/dependency note

Validation

npm run lint -- --quiet
npm run typecheck
npm run validate:manifest
npm test -- tests/memory/claude-md-ownership.test.js --runInBand --forceExit
npm test -- --runInBand --forceExit

Note: the full Jest suite passed with 317 suites passed, 11 skipped; 7878 tests passed, 149 skipped. The suite transiently regenerates .aiox-core/data/entity-registry.yaml timestamps locally; that generated noise was restored before commit.

Relationship

Supersedes #678.

Summary by CodeRabbit

Configuration
- Added Portuguese language support to system settings.
- Expanded environment configuration template with support for multiple LLM providers (DeepSeek, OpenRouter, Anthropic, OpenAI) and additional integrations (Supabase, Exa, ClickUp, N8N, Sentry, deployment tools).
Documentation
- Established governance framework for evolution pipeline, squad activation strategies, and audit processes.
- Added project structure documentation and patterns catalog.

…md ao atingir 5+ Estabelece regra operacional de governança de pipelines longos: - Threshold: 5+ handoffs YAML para mesmo pipeline → MUST consolidar - RUN-LOG.md vai em docs/stories/epics/{epic}/RUN-LOG.md (preferred) - Handoff mais recente sempre fica individual (next session reads first) - Originais arquivados em .aiox/handoffs/_archive/ (default) - Preserva: contexto estratégico, ADRs, blockers resolvidos, schema changes - Descarta: investigation steps, alternativas rejeitadas, tool sequences Trigger desta sessão: pipeline meta-messaging Wave 1 → Wave 2 transition. Mirror em business-ai-first/.claude/rules/handoff-consolidation.md (PR #59). Atualiza CLAUDE.md (tabela de rules) com referência à nova regra. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

) Establishes formal AIOX framework R&D pipeline triggered by Wave 1.A correction in business-ai-first that exposed two systemic gaps: 1. No formal route for project-level audit findings to evolve framework 2. @aiox-master orchestrator has no triage.routing_matrix to consult specialized squads first when topic matches their domain ## What this PR adds ### audits/ - README.md — folder doctrine - c-dev-organization-2026-05-07.md — narrative audit of C:/dev workspace - promoted/AF-20260507-vocabulary-contract-failure.yaml — finding - promoted/AF-20260507-aiox-master-routing-gap.yaml — finding ### governance/ - README.md — folder index - evolution-pipeline.md — formal R&D pipeline spec (audit -> proposal -> Eliel approval -> PR) - squad-activation-strategy.md — conditional consult-squad-first routing - templates/audit-finding-tmpl.yaml — AuditFinding template - templates/framework-proposal-tmpl.yaml — FrameworkProposal template - proposals/README.md — proposal lifecycle doc - proposals/PROP-20260507-vocabulary-contract.yaml — pending Eliel approval - proposals/PROP-20260507-squad-routing-strategy.yaml — pending Eliel approval - patterns/README.md — pattern catalog (catalog scaffold) ## Why this matters Without the pipeline, every project re-discovers the same lessons, voice-clone squads stay dormant, claude-code-mastery never gets invoked from outside, and tokens burn on context redundancy. Eliel's diagnostic: "todos os plans criados cogitaram em nenhum momento a perfeita integração desses squads". The pipeline is the discipline; the routing matrix is the mechanism. ## What this PR does NOT do (deferred to follow-up PRs after approval) - Patch aiox-master.md to add triage block (separate PR per proposal approval) - Add aiox-core/hooks/migration-dictionary-guard.cjs (separate PR) - Add aiox-core/hooks/squad-suggestion-advisor.cjs (separate PR) - Constitution amendment Article VII (separate PR) This PR is governance-only. Implementation follows once Eliel signs the two pending proposals. ## Authority - Authors: @aiox-master (Orion) on Eliel's request - Approver of governance content: Eliel (sole orchestrator approver) - Reference: voice-clone formal opinions captured in business-ai-first ADR-DBOPS-V1-vocabulary-contract-failure.md Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Eliel approved both proposals on 2026-05-07T19:15:00Z: - PROP-20260507-vocabulary-contract: APPROVED Closes Akita's Article VII gap. Generalizes migration-dictionary-guard hook from business-ai-first project-local copy to framework. Prevents Wave 1.A failure mode (V1 reverted) in any future AIOX project. - PROP-20260507-squad-routing-strategy: APPROVED Adds triage.routing_matrix to @aiox-master. Advisory hook suggests squads (voice-clones, claude-code-mastery, audience-engine, db-inventory) by keyword match. Closes Eliel-declared squad integration gap. Implementation order: vocabulary-contract first, then squad-routing references Article VII once formalized. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

…oved

vercel · 2026-05-07T23:42:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
aiox-core	Ready	Preview, Comment	May 7, 2026 11:42pm

github-actions · 2026-05-07T23:44:03Z

📊 Coverage Report

Coverage report not available

📈 Full coverage report available in Codecov

Generated by PR Automation (Story 6.1)

coderabbitai · 2026-05-07T23:46:25Z

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR establishes a formal AIOX framework governance process with audit-finding and proposal templates, documents two concrete framework gaps (missing squad routing and vocabulary-contract enforcement), approves two strategic proposals to address those gaps, defines approved patterns with complete routing logic and implementation specs, and updates local configuration and environment templates.

Changes

Framework Governance & Evolution Pipeline

Layer / File(s)	Summary
Governance Process & Roles `governance/evolution-pipeline.md`, `governance/README.md`	Formalizes the evolution pipeline with roles (Auditor, Proposer, Approver, Implementer, Distributor), trigger conditions, decision flows, and operational rules for framework changes.
Audit Finding & Proposal Schemas `governance/templates/audit-finding-tmpl.yaml`, `governance/templates/framework-proposal-tmpl.yaml`	Defines YAML schemas for `audit_finding` and `framework_proposal` with required fields for identifiers, evidence, rationale, target operations, and approval tracking.
Concrete Audit Findings `audits/README.md`, `audits/promoted/AF-20260507-*.yaml`	Documents two framework-level findings: `@aiox-master` lacks `triage.routing_matrix` (blocking squad auto-consult) and vocabulary-contract enforcement gap (allowed invalid migrations).
Framework Proposals `governance/proposals/README.md`, `governance/proposals/PROP-20260507-*.yaml`	Proposes and approves squad-routing-strategy (add routing matrix + squad-suggestion-advisor hook) and vocabulary-contract (add pre-flight enforcement + constitution amendment).
Approved Patterns & Strategy `governance/patterns/README.md`, `governance/squad-activation-strategy.md`	Catalogs approved patterns and defines squad-activation-routing with complete keyword-to-squad matrix, design principles, hook spec, and rollout plan.
Local Configuration & Example `.claude/CLAUDE.md`, `.claude/settings.json`, `.claude/rules/handoff-consolidation.md`, `.claude/commands/AIOX/stories/story-7.1.1.md`, `.env.example`, `audits/c-dev-organization-2026-05-07.md`	Updates Claude Code config structure, adds Portuguese language setting, defines handoff consolidation rule, creates dev bootstrap story, refreshes env template with LLM/tool/backend credentials, and provides workspace audit with proposed directory organization.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

type: docs

Suggested reviewers

Pedrovaleriolopez
oalanicolas

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'chore(governance): approve proposals and apply review fixes' accurately and concisely describes the main changes: governance proposal approvals and review fixes from PR `#678`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch devops/pr-678-governance-review-fixes-20260507

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Alencaf and others added 6 commits May 5, 2026 17:02

chore(war-room): local Claude Code integration and env setup

9142271

Merge remote-tracking branch 'origin/main' into pr-678-proposals-appr…

f90ac46

…oved

fix: address governance proposal review [PR #678]

6d2c9a1

rafaelscosta requested review from Pedrovaleriolopez and oalanicolas as code owners May 7, 2026 23:42

rafaelscosta merged commit fb312dd into main May 7, 2026
30 of 31 checks passed

rafaelscosta deleted the devops/pr-678-governance-review-fixes-20260507 branch May 7, 2026 23:50

rafaelscosta mentioned this pull request May 7, 2026

fix: address governance PR review feedback #681

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(governance): approve proposals and apply review fixes - #682

chore(governance): approve proposals and apply review fixes#682
rafaelscosta merged 6 commits into
mainfrom
devops/pr-678-governance-review-fixes-20260507

rafaelscosta commented May 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

coderabbitai Bot commented May 7, 2026 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

rafaelscosta commented May 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Relationship

Summary by CodeRabbit

Uh oh!

vercel Bot commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

📊 Coverage Report

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rafaelscosta commented May 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading