fix: repair Pro installer npx commands - #726
Merged
Merged
Conversation
rafaelscosta
requested review from
Pedrovaleriolopez and
oalanicolas
as code owners
May 12, 2026 17:32
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
type: test
Contributor
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR transitions the AIOX Pro CLI invocation pattern from legacy ChangesAIOX Pro CLI Command Invocation Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pro-integration.yml:
- Around line 89-94: The workflow currently sets a global credentialized URL
with git config using the PRO_SUBMODULE_TOKEN and relies on the final git config
--unset-all cleanup line to run, but that line can be skipped if git submodule
sync/update fails; update the run block so the credentialized config is written
to repo-local scope (use git config --local insteadOf) or wrap the sequence in a
shell trap/finally to always execute the cleanup unset (referencing the existing
git config
url."https://x-access-token:${PRO_SUBMODULE_TOKEN}@github.com/SynkraAI/".insteadOf,
the git submodule sync/update commands, and the git config --unset-all cleanup)
so the tokenized URL is removed even on failure.
In `@tests/pro-wizard.test.js`:
- Line 57: Replace the relative require in tests/pro-wizard.test.js that assigns
wizardI18n from '../packages/installer/src/wizard/i18n' with the project’s
absolute import pattern; locate the line where const wizardI18n =
require('../packages/installer/src/wizard/i18n') is declared and change it to
use the repository's absolute module path (preserving the symbol wizardI18n) so
it complies with the /*.{js,jsx,ts,tsx} absolute import guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a39d1080-40d6-4a47-a33b-7f8085111c84
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (14)
.github/workflows/pro-integration.ymlREADME.mddocs/guides/aiox-pro-access.mddocs/guides/pro/install-gate-setup.mddocs/guides/workflows/pro-developer-workflow.mddocs/stories/epic-pro-13/STORY-PRO-13.5-PRIVATE-PRO-DISTRIBUTION-HARDENING.mdpackages/aiox-pro-cli/bin/aiox-pro.jspackages/aiox-pro-cli/package.jsonpackages/installer/package.jsonpackages/installer/src/pro/pro-scaffolder.jspackages/installer/src/wizard/i18n.jspackages/installer/src/wizard/pro-setup.jstests/pro-recover.test.jstests/pro-wizard.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx aiox-prorecovery/setup hints with published scoped commandsValidation
npm run lintPASSnpm run typecheckPASSnpm run validate:publishPASSnpm test -- --runInBand tests/pro-wizard.test.js tests/installer/pro-setup-auth.test.js tests/pro-recover.test.js tests/installer/pro-scaffolder.test.jsPASSnpm pack --workspace @aiox-squads/aiox-pro-cli --dry-run --jsonPASSnpm pack --workspace @aiox-squads/installer --dry-run --jsonPASSnpm test -- --runInBandhad 2 transient failures outside this patch; both failed suites passed when rerun directly:tests/unit/squad/squad-generator-blueprint.test.jsandtests/integration/hooks/precompact-flow.integration.test.jsNotes
prosubmodule pointer change.aios-license-server@856dee5.Summary by CodeRabbit